Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Issue 307963007: Removes ContextFactory::Get/SetInstance (Closed)

Created:
6 years, 6 months ago by sky
Modified:
6 years, 6 months ago
Reviewers:
piman
CC:
chromium-reviews, cc-bugs_chromium.org, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, Ian Vollick, tfarina, ben+aura_chromium.org, jam, yzshen+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), ben+ash_chromium.org
Visibility:
Public.

Description

Removes ContextFactory::Get/SetInstance BUG=379399 TEST=none TBR=piman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274283

Patch Set 1 #

Patch Set 2 : moar #

Patch Set 3 : fix mac #

Patch Set 4 : merge 2 trunk #

Patch Set 5 : fix aura_bench #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -61 lines) Patch
M content/browser/compositor/image_transport_factory.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/aura/bench/bench_main.cc View 1 2 3 4 3 chunks +7 lines, -4 lines 0 comments Download
M ui/compositor/compositor.h View 1 3 chunks +0 lines, -16 lines 0 comments Download
M ui/compositor/compositor.cc View 3 chunks +0 lines, -39 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
sky
I'm TBRing this as it's just dead code removal at this point.
6 years, 6 months ago (2014-06-01 19:51:50 UTC) #1
sky
The CQ bit was checked by sky@chromium.org
6 years, 6 months ago (2014-06-01 19:51:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/307963007/60001
6 years, 6 months ago (2014-06-01 19:52:11 UTC) #3
tfarina
This probably fixes http://crbug.com/379399
6 years, 6 months ago (2014-06-01 19:54:31 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-02 00:47:17 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-02 01:19:21 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/33145)
6 years, 6 months ago (2014-06-02 01:19:21 UTC) #7
piman
LGTM, woot!
6 years, 6 months ago (2014-06-02 06:51:27 UTC) #8
sky
The CQ bit was checked by sky@chromium.org
6 years, 6 months ago (2014-06-02 14:51:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/307963007/80001
6 years, 6 months ago (2014-06-02 14:53:49 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 18:14:05 UTC) #11
Message was sent while issue was closed.
Change committed as 274283

Powered by Google App Engine
This is Rietveld 408576698