Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issue 307963005: Fix incorrectly disabled SSE2 WebAudio optimizations for Windows. (Closed)

Created:
6 years, 6 months ago by DaleCurtis
Modified:
6 years, 6 months ago
Reviewers:
Raymond Toy
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Fix incorrectly disabled SSE2 WebAudio optimizations for Windows. MSVC doesn't set __SSE__ or__SSE2__ defines: http://msdn.microsoft.com/en-us/library/b0084kay.aspx BUG=349320 TEST=compiles Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175173

Patch Set 1 #

Patch Set 2 : Fix checks. Rebaseline. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -12 lines) Patch
M LayoutTests/platform/win/webaudio/codec-tests/wav/24bit-22khz-resample-expected.wav View 1 Binary file 0 comments Download
M Source/platform/audio/SincResampler.cpp View 1 2 chunks +3 lines, -2 lines 0 comments Download
M Source/platform/audio/VectorMath.cpp View 1 10 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
DaleCurtis
6 years, 6 months ago (2014-05-29 22:45:44 UTC) #1
Raymond Toy
lgtm overall, but are we certain that all x86 platforms will now run with SSE2? ...
6 years, 6 months ago (2014-05-29 23:13:35 UTC) #2
DaleCurtis
Yes, that's my understanding. OSX is already like SSSE3 and Linux and Windows are now ...
6 years, 6 months ago (2014-05-29 23:19:57 UTC) #3
DaleCurtis
The CQ bit was checked by dalecurtis@chromium.org
6 years, 6 months ago (2014-05-29 23:20:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/307963005/1
6 years, 6 months ago (2014-05-29 23:22:24 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-05-30 14:37:27 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-30 15:18:17 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/10123)
6 years, 6 months ago (2014-05-30 15:18:17 UTC) #8
Raymond Toy
On 2014/05/30 15:18:17, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 6 months ago (2014-05-30 16:12:33 UTC) #9
DaleCurtis
Hmm, I'll see if I can rebaseline in this CL too.
6 years, 6 months ago (2014-05-30 17:07:35 UTC) #10
DaleCurtis
PTAL. Turns out I actually disabled SSE on x64 which is what caused Linux to ...
6 years, 6 months ago (2014-05-30 18:43:44 UTC) #11
Raymond Toy
lgtm
6 years, 6 months ago (2014-05-30 18:46:58 UTC) #12
DaleCurtis
The CQ bit was checked by dalecurtis@chromium.org
6 years, 6 months ago (2014-05-30 19:40:49 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/307963005/20001
6 years, 6 months ago (2014-05-30 19:42:18 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-05-30 22:35:53 UTC) #15
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 23:36:37 UTC) #16
Message was sent while issue was closed.
Change committed as 175173

Powered by Google App Engine
This is Rietveld 408576698