Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 307953002: msvs: Revert r1920 and add a test for excluded idl (Closed)

Created:
6 years, 6 months ago by Shezan Baig (Bloomberg)
Modified:
6 years, 6 months ago
Reviewers:
scottmg
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

msvs: Revert r1920 and add a test for excluded idl The test uses a "bad" idl to verify that it gets excluded from the msvs build. If it doesn't get excluded, then the build will fail because the bad.idl is syntactically wrong. BUG= R=scottmg@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1925

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -5 lines) Patch
M pylib/gyp/generator/msvs.py View 2 chunks +2 lines, -2 lines 0 comments Download
A + test/win/gyptest-midl-excluded.py View 2 chunks +5 lines, -5 lines 0 comments Download
A test/win/idl-excluded/bad.idl View 1 chunk +6 lines, -0 lines 0 comments Download
A + test/win/idl-excluded/copy-file.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A test/win/idl-excluded/idl-excluded.gyp View 1 chunk +58 lines, -0 lines 0 comments Download
A + test/win/idl-excluded/program.cc View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Shezan Baig (Bloomberg)
This is to fix a regression from r1920 (see discussion at https://codereview.chromium.org/282843002/)
6 years, 6 months ago (2014-05-29 15:47:06 UTC) #1
scottmg
Thanks, lgtm.
6 years, 6 months ago (2014-05-29 15:56:44 UTC) #2
Shezan Baig (Bloomberg)
Committed patchset #1 manually as r1925 (presubmit successful).
6 years, 6 months ago (2014-05-29 19:15:42 UTC) #3
Romain Pokrzywka
6 years, 6 months ago (2014-05-31 00:23:12 UTC) #4
Message was sent while issue was closed.
On 2014/05/29 19:15:42, Shezan Baig (Bloomberg) wrote:
> Committed patchset #1 manually as r1925 (presubmit successful).

Thanks!
Romain

Powered by Google App Engine
This is Rietveld 408576698