chrome/installer/setup/install_worker.cc - Issue 307943008: Fixed mistake in logical check for rollback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/setup/install_worker.cc

Issue 307943008: Fixed mistake in logical check for rollback. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Thu 05/29/2014 17:03:43.93 Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/setup/install_worker.cc

diff --git a/chrome/installer/setup/install_worker.cc b/chrome/installer/setup/install_worker.cc

index deef6aa5521ddb334e8a8ef073576d43ea64282c..8fab21273e5a115b3cb3efb20c271508abd13115 100644

--- a/chrome/installer/setup/install_worker.cc

+++ b/chrome/installer/setup/install_worker.cc

@@ -269,7 +269,7 @@ bool AddFirewallRulesCallback(bool system_level,

bool remove_on_rollback,

const CallbackWorkItem& work_item) {

// There is no work to do on rollback if this is not a new install.

- if (work_item.IsRollback() || !remove_on_rollback)

+ if (work_item.IsRollback() && !remove_on_rollback)

return true;

scoped_ptr<FirewallManager> manager =

« no previous file with comments | « no previous file | no next file » | no next file with comments »