Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 307943004: Adds bluetooth connection type to NetworkChangeNotifier. (Closed)

Created:
6 years, 6 months ago by jkarlin
Modified:
6 years, 6 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, jar (doing other things), jam, darin-cc_chromium.org, asvitkine+watch_chromium.org, chromium-apps-reviews_chromium.org, Ilya Sherman
Base URL:
https://chromium.googlesource.com/chromium/src.git@netinfo
Visibility:
Public.

Description

Adds bluetooth connection type to NetworkChangeNotifier. This is for compliance with NetInfov3 (http://w3c.github.io/netinfo/). BUG=378785 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274817

Patch Set 1 #

Patch Set 2 : More instances #

Patch Set 3 : Move chromeos and android changes to their own cls #

Patch Set 4 : Everything I could find in a grep #

Total comments: 2

Patch Set 5 : Adds browser test to see if bluetooth type crashes anything #

Patch Set 6 : Removing browser test as it only needs to be tested for initial landing #

Total comments: 2

Patch Set 7 : Updating spec url #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -6 lines) Patch
M chrome/browser/extensions/api/dial/dial_registry.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/metrics/network_metrics_provider.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/metrics/proto/system_profile.proto View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/net_info_helper.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/base/network_change_notifier.h View 1 2 3 4 5 6 2 chunks +4 lines, -3 lines 0 comments Download
M net/base/network_change_notifier.cc View 1 5 chunks +18 lines, -3 lines 0 comments Download
M net/tools/net_watcher/net_watcher.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
jkarlin
pauljensen: Please review everything.
6 years, 6 months ago (2014-05-29 18:08:10 UTC) #1
jkarlin
rch: Please review the change to histograms.xml
6 years, 6 months ago (2014-05-29 18:21:24 UTC) #2
jkarlin
On 2014/05/29 18:21:24, jkarlin wrote: > rch: Please review the change to histograms.xml ^^ Because ...
6 years, 6 months ago (2014-05-29 18:22:03 UTC) #3
Ryan Hamilton
histograms.xml LGTM, but you'll need a histograms OWNER to approve, I think.
6 years, 6 months ago (2014-05-29 18:25:41 UTC) #4
Ilya Sherman
https://codereview.chromium.org/307943004/diff/60001/components/metrics/proto/system_profile.proto File components/metrics/proto/system_profile.proto (right): https://codereview.chromium.org/307943004/diff/60001/components/metrics/proto/system_profile.proto#newcode271 components/metrics/proto/system_profile.proto:271: CONNECTION_BLUETOOTH = 6; Please note that you'll need to ...
6 years, 6 months ago (2014-05-29 18:57:19 UTC) #5
pauljensen
I think you'll break this: https://code.google.com/p/chromium/codesearch#chromium/src/content/common/p2p_messages.h&l=28 https://codereview.chromium.org/307943004/diff/100001/net/base/network_change_notifier.h File net/base/network_change_notifier.h (right): https://codereview.chromium.org/307943004/diff/100001/net/base/network_change_notifier.h#newcode36 net/base/network_change_notifier.h:36: // http://www.w3.org/TR/netinfo-api. This ...
6 years, 6 months ago (2014-05-30 11:43:10 UTC) #6
jkarlin
The p2p_messages.h code has changed (https://codereview.chromium.org/298803006/) since code search last updated and there is no ...
6 years, 6 months ago (2014-05-30 11:53:08 UTC) #7
pauljensen
lgtm
6 years, 6 months ago (2014-05-30 12:18:18 UTC) #8
jkarlin
https://codereview.chromium.org/307943004/diff/60001/components/metrics/proto/system_profile.proto File components/metrics/proto/system_profile.proto (right): https://codereview.chromium.org/307943004/diff/60001/components/metrics/proto/system_profile.proto#newcode271 components/metrics/proto/system_profile.proto:271: CONNECTION_BLUETOOTH = 6; On 2014/05/29 18:57:19, Ilya Sherman wrote: ...
6 years, 6 months ago (2014-05-30 21:22:10 UTC) #9
Ilya Sherman
metrics changes lgtm
6 years, 6 months ago (2014-05-30 22:50:09 UTC) #10
jkarlin
mfoltz: Please reivew extensions/api/dial/ jamesr: Please review content/renderer/
6 years, 6 months ago (2014-06-02 13:08:01 UTC) #11
mark a. foltz
lgtm
6 years, 6 months ago (2014-06-02 22:19:37 UTC) #12
mark a. foltz
lgtm
6 years, 6 months ago (2014-06-02 22:19:38 UTC) #13
jamesr
lgtm, but it seems really bizarre to expose this sort of information to a web ...
6 years, 6 months ago (2014-06-02 22:35:03 UTC) #14
jkarlin
On 2014/06/02 22:35:03, jamesr wrote: > lgtm, but it seems really bizarre to expose this ...
6 years, 6 months ago (2014-06-03 11:03:25 UTC) #15
jkarlin
The CQ bit was checked by jkarlin@chromium.org
6 years, 6 months ago (2014-06-03 11:03:35 UTC) #16
jkarlin
The CQ bit was unchecked by jkarlin@chromium.org
6 years, 6 months ago (2014-06-03 11:03:37 UTC) #17
jkarlin
The CQ bit was checked by jkarlin@chromium.org
6 years, 6 months ago (2014-06-04 11:08:51 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jkarlin@chromium.org/307943004/120001
6 years, 6 months ago (2014-06-04 11:11:09 UTC) #19
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-06-04 12:38:17 UTC) #20
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 14:08:43 UTC) #21
Message was sent while issue was closed. 
Change committed as 274817

Powered by Google App Engine
This is Rietveld 408576698