Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3637)

Unified Diff: Source/modules/geolocation/GeolocationController.cpp

Issue 307943002: Oilpan: Prepare moving InspectorController and InspectorAgents to oilpan. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/geolocation/GeolocationController.cpp
diff --git a/Source/modules/geolocation/GeolocationController.cpp b/Source/modules/geolocation/GeolocationController.cpp
index a0cd1b75318d0303531c54a88f1914d84dfd91b4..fea1c7b2a6f8f2bea904eaf825289a49d74d8e4e 100644
--- a/Source/modules/geolocation/GeolocationController.cpp
+++ b/Source/modules/geolocation/GeolocationController.cpp
@@ -47,15 +47,14 @@ GeolocationController::GeolocationController(LocalFrame& frame, GeolocationClien
// it and this class. Until then, there's one GeolocationInspectorAgent per page that the main
// frame is responsible for creating.
if (frame.isMainFrame()) {
- OwnPtr<GeolocationInspectorAgent> geolocationAgent(GeolocationInspectorAgent::create());
+ OwnPtrWillBeRawPtr<GeolocationInspectorAgent> geolocationAgent(GeolocationInspectorAgent::create());
m_inspectorAgent = geolocationAgent.get();
frame.page()->inspectorController().registerModuleAgent(geolocationAgent.release());
} else if (frame.page()->mainFrame()->isLocalFrame()) {
m_inspectorAgent = GeolocationController::from(frame.page()->deprecatedLocalMainFrame())->m_inspectorAgent;
}
- if (m_inspectorAgent)
- m_inspectorAgent->AddController(this);
+ m_inspectorAgent->addController(this);
if (!frame.isMainFrame() && frame.page()->mainFrame()->isLocalFrame()) {
// internals.setGeolocationClientMock is per page.
@@ -89,10 +88,12 @@ GeolocationController::~GeolocationController()
void GeolocationController::detach()
{
+#if !ENABLE(OILPAN)
if (page() && m_inspectorAgent) {
- m_inspectorAgent->RemoveController(this);
- m_inspectorAgent = 0;
+ m_inspectorAgent->removeController(this);
+ m_inspectorAgent = nullptr;
}
+#endif
if (m_hasClientForTest) {
m_client->controllerForTestRemoved(this);
@@ -230,6 +231,7 @@ void GeolocationController::trace(Visitor* visitor)
visitor->trace(m_lastPosition);
visitor->trace(m_observers);
visitor->trace(m_highAccuracyObservers);
+ visitor->trace(m_inspectorAgent);
WillBeHeapSupplement<LocalFrame>::trace(visitor);
}
« no previous file with comments | « Source/modules/geolocation/GeolocationController.h ('k') | Source/modules/geolocation/GeolocationInspectorAgent.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698