Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1069)

Unified Diff: Source/core/inspector/InspectorTimelineAgent.h

Issue 307943002: Oilpan: Prepare moving InspectorController and InspectorAgents to oilpan. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixed Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/inspector/InspectorTimelineAgent.h
diff --git a/Source/core/inspector/InspectorTimelineAgent.h b/Source/core/inspector/InspectorTimelineAgent.h
index c193b6553902a7b4261d569b5942956e92840fe8..9100b942f2a503b2f4401a54b42b7c694082e71e 100644
--- a/Source/core/inspector/InspectorTimelineAgent.h
+++ b/Source/core/inspector/InspectorTimelineAgent.h
@@ -89,8 +89,8 @@ class XMLHttpRequest;
typedef String ErrorString;
class InspectorTimelineAgent FINAL
- : public TraceEventTarget<InspectorTimelineAgent>
- , public InspectorBaseAgent<InspectorTimelineAgent>
+ : public InspectorBaseAgent<InspectorTimelineAgent>
yurys 2014/06/18 14:23:37 Why did this change?
keishi 2014/06/18 14:47:09 We need the GarbageCollected class needs to be lef
+ , public TraceEventTarget<InspectorTimelineAgent>
, public ScriptGCEventListener
, public InspectorBackendDispatcher::TimelineCommandHandler
, public PlatformInstrumentationClient {
@@ -114,13 +114,14 @@ public:
uint64_t limitGPUMemoryBytes;
};
- static PassOwnPtr<InspectorTimelineAgent> create(InspectorPageAgent* pageAgent, InspectorLayerTreeAgent* layerTreeAgent,
+ static PassOwnPtrWillBeRawPtr<InspectorTimelineAgent> create(InspectorPageAgent* pageAgent, InspectorLayerTreeAgent* layerTreeAgent,
InspectorOverlay* overlay, InspectorType type, InspectorClient* client)
{
- return adoptPtr(new InspectorTimelineAgent(pageAgent, layerTreeAgent, overlay, type, client));
+ return adoptPtrWillBeNoop(new InspectorTimelineAgent(pageAgent, layerTreeAgent, overlay, type, client));
}
virtual ~InspectorTimelineAgent();
+ virtual void trace(Visitor*) OVERRIDE;
virtual void setFrontend(InspectorFrontend*) OVERRIDE;
virtual void clearFrontend() OVERRIDE;
@@ -286,8 +287,8 @@ private:
void innerStop(bool fromConsole);
void setLiveEvents(const String&);
- InspectorPageAgent* m_pageAgent;
- InspectorLayerTreeAgent* m_layerTreeAgent;
+ RawPtrWillBeMember<InspectorPageAgent> m_pageAgent;
+ RawPtrWillBeMember<InspectorLayerTreeAgent> m_layerTreeAgent;
InspectorFrontend::Timeline* m_frontend;
InspectorClient* m_client;
InspectorOverlay* m_overlay;

Powered by Google App Engine
This is Rietveld 408576698