Index: Source/core/inspector/InspectorController.cpp |
diff --git a/Source/core/inspector/InspectorController.cpp b/Source/core/inspector/InspectorController.cpp |
index 0d868c44dc3e537f9646ddbb5433e13ac381f2de..7a24b50826f970f2b670f3841c11fdf22ac3713d 100644 |
--- a/Source/core/inspector/InspectorController.cpp |
+++ b/Source/core/inspector/InspectorController.cpp |
@@ -75,7 +75,7 @@ InspectorController::InspectorController(Page* page, InspectorClient* inspectorC |
, m_injectedScriptManager(InjectedScriptManager::createForPage()) |
, m_state(adoptPtr(new InspectorCompositeState(inspectorClient))) |
, m_overlay(InspectorOverlay::create(page, inspectorClient)) |
- , m_layerTreeAgent(0) |
+ , m_layerTreeAgent(nullptr) |
, m_page(page) |
, m_inspectorClient(inspectorClient) |
, m_agents(m_instrumentingAgents.get(), m_state.get()) |
@@ -85,37 +85,37 @@ InspectorController::InspectorController(Page* page, InspectorClient* inspectorC |
InjectedScriptManager* injectedScriptManager = m_injectedScriptManager.get(); |
InspectorOverlay* overlay = m_overlay.get(); |
- m_agents.append(InspectorInspectorAgent::create(m_page, injectedScriptManager)); |
+ agents().append(InspectorInspectorAgent::create(m_page, injectedScriptManager)); |
- OwnPtr<InspectorPageAgent> pageAgentPtr(InspectorPageAgent::create(m_page, injectedScriptManager, inspectorClient, overlay)); |
+ OwnPtrWillBeRawPtr<InspectorPageAgent> pageAgentPtr(InspectorPageAgent::create(m_page, injectedScriptManager, inspectorClient, overlay)); |
m_pageAgent = pageAgentPtr.get(); |
- m_agents.append(pageAgentPtr.release()); |
+ agents().append(pageAgentPtr.release()); |
yurys
2014/06/18 14:23:37
What's the point in having agents() compared to us
keishi
2014/06/18 14:47:09
I'm not sure. tkent@ could you explain?
https://co
tkent
2014/06/18 23:21:29
m_agents is always non-null, and we prefer using r
|
- OwnPtr<InspectorDOMAgent> domAgentPtr(InspectorDOMAgent::create(m_pageAgent, injectedScriptManager, overlay)); |
+ OwnPtrWillBeRawPtr<InspectorDOMAgent> domAgentPtr(InspectorDOMAgent::create(m_pageAgent, injectedScriptManager, overlay)); |
m_domAgent = domAgentPtr.get(); |
- m_agents.append(domAgentPtr.release()); |
+ agents().append(domAgentPtr.release()); |
- OwnPtr<InspectorLayerTreeAgent> layerTreeAgentPtr(InspectorLayerTreeAgent::create(m_page)); |
+ OwnPtrWillBeRawPtr<InspectorLayerTreeAgent> layerTreeAgentPtr(InspectorLayerTreeAgent::create(m_page)); |
m_layerTreeAgent = layerTreeAgentPtr.get(); |
- m_agents.append(layerTreeAgentPtr.release()); |
+ agents().append(layerTreeAgentPtr.release()); |
- OwnPtr<InspectorTracingAgent> tracingAgentPtr = InspectorTracingAgent::create(inspectorClient); |
+ OwnPtrWillBeRawPtr<InspectorTracingAgent> tracingAgentPtr = InspectorTracingAgent::create(inspectorClient); |
m_tracingAgent = tracingAgentPtr.get(); |
- m_agents.append(tracingAgentPtr.release()); |
+ agents().append(tracingAgentPtr.release()); |
- OwnPtr<InspectorTimelineAgent> timelineAgentPtr(InspectorTimelineAgent::create(m_pageAgent, m_layerTreeAgent, |
+ OwnPtrWillBeRawPtr<InspectorTimelineAgent> timelineAgentPtr(InspectorTimelineAgent::create(m_pageAgent, m_layerTreeAgent, |
overlay, InspectorTimelineAgent::PageInspector, inspectorClient)); |
m_timelineAgent = timelineAgentPtr.get(); |
- m_agents.append(timelineAgentPtr.release()); |
+ agents().append(timelineAgentPtr.release()); |
PageScriptDebugServer* pageScriptDebugServer = &PageScriptDebugServer::shared(); |
- m_agents.append(PageRuntimeAgent::create(injectedScriptManager, pageScriptDebugServer, m_page, m_pageAgent)); |
+ agents().append(PageRuntimeAgent::create(injectedScriptManager, pageScriptDebugServer, m_page, m_pageAgent)); |
- m_agents.append(PageConsoleAgent::create(injectedScriptManager, m_domAgent, m_timelineAgent)); |
+ agents().append(PageConsoleAgent::create(injectedScriptManager, m_domAgent, m_timelineAgent)); |
- m_agents.append(InspectorWorkerAgent::create()); |
+ agents().append(InspectorWorkerAgent::create()); |
ASSERT_ARG(inspectorClient, inspectorClient); |
m_injectedScriptManager->injectedScriptHost()->init(m_instrumentingAgents.get(), pageScriptDebugServer); |
@@ -125,9 +125,24 @@ InspectorController::~InspectorController() |
{ |
} |
-PassOwnPtr<InspectorController> InspectorController::create(Page* page, InspectorClient* client) |
+void InspectorController::trace(Visitor* visitor) |
{ |
- return adoptPtr(new InspectorController(page, client)); |
+ visitor->trace(m_instrumentingAgents); |
+ visitor->trace(m_domAgent); |
+ visitor->trace(m_pageAgent); |
+ visitor->trace(m_timelineAgent); |
+ visitor->trace(m_layerTreeAgent); |
+ visitor->trace(m_tracingAgent); |
+ visitor->trace(m_page); |
+ m_agents.trace(visitor); |
+#if ENABLE(OILPAN) |
+ visitor->trace(m_moduleAgents); |
+#endif |
+} |
+ |
+PassOwnPtrWillBeRawPtr<InspectorController> InspectorController::create(Page* page, InspectorClient* client) |
+{ |
+ return adoptPtrWillBeNoop(new InspectorController(page, client)); |
} |
void InspectorController::setTextAutosizingEnabled(bool enabled) |
@@ -149,33 +164,33 @@ void InspectorController::initializeDeferredAgents() |
InjectedScriptManager* injectedScriptManager = m_injectedScriptManager.get(); |
InspectorOverlay* overlay = m_overlay.get(); |
- OwnPtr<InspectorResourceAgent> resourceAgentPtr(InspectorResourceAgent::create(m_pageAgent)); |
+ OwnPtrWillBeRawPtr<InspectorResourceAgent> resourceAgentPtr(InspectorResourceAgent::create(m_pageAgent)); |
InspectorResourceAgent* resourceAgent = resourceAgentPtr.get(); |
- m_agents.append(resourceAgentPtr.release()); |
+ agents().append(resourceAgentPtr.release()); |
- m_agents.append(InspectorCSSAgent::create(m_domAgent, m_pageAgent, resourceAgent)); |
+ agents().append(InspectorCSSAgent::create(m_domAgent, m_pageAgent, resourceAgent)); |
- m_agents.append(InspectorDOMStorageAgent::create(m_pageAgent)); |
+ agents().append(InspectorDOMStorageAgent::create(m_pageAgent)); |
- m_agents.append(InspectorMemoryAgent::create()); |
+ agents().append(InspectorMemoryAgent::create()); |
- m_agents.append(InspectorApplicationCacheAgent::create(m_pageAgent)); |
+ agents().append(InspectorApplicationCacheAgent::create(m_pageAgent)); |
PageScriptDebugServer* pageScriptDebugServer = &PageScriptDebugServer::shared(); |
- OwnPtr<InspectorDebuggerAgent> debuggerAgentPtr(PageDebuggerAgent::create(pageScriptDebugServer, m_pageAgent, injectedScriptManager, overlay)); |
+ OwnPtrWillBeRawPtr<InspectorDebuggerAgent> debuggerAgentPtr(PageDebuggerAgent::create(pageScriptDebugServer, m_pageAgent, injectedScriptManager, overlay)); |
InspectorDebuggerAgent* debuggerAgent = debuggerAgentPtr.get(); |
- m_agents.append(debuggerAgentPtr.release()); |
+ agents().append(debuggerAgentPtr.release()); |
- m_agents.append(InspectorDOMDebuggerAgent::create(m_domAgent, debuggerAgent)); |
+ agents().append(InspectorDOMDebuggerAgent::create(m_domAgent, debuggerAgent)); |
- m_agents.append(InspectorProfilerAgent::create(injectedScriptManager, overlay)); |
+ agents().append(InspectorProfilerAgent::create(injectedScriptManager, overlay)); |
- m_agents.append(InspectorHeapProfilerAgent::create(injectedScriptManager)); |
+ agents().append(InspectorHeapProfilerAgent::create(injectedScriptManager)); |
- m_agents.append(InspectorCanvasAgent::create(m_pageAgent, injectedScriptManager)); |
+ agents().append(InspectorCanvasAgent::create(m_pageAgent, injectedScriptManager)); |
- m_agents.append(InspectorInputAgent::create(m_page, m_inspectorClient)); |
+ agents().append(InspectorInputAgent::create(m_page, m_inspectorClient)); |
} |
void InspectorController::willBeDestroyed() |
@@ -183,15 +198,15 @@ void InspectorController::willBeDestroyed() |
disconnectFrontend(); |
m_injectedScriptManager->disconnect(); |
m_inspectorClient = 0; |
- m_page = 0; |
+ m_page = nullptr; |
m_instrumentingAgents->reset(); |
- m_agents.discardAgents(); |
+ agents().discardAgents(); |
} |
-void InspectorController::registerModuleAgent(PassOwnPtr<InspectorAgent> agent) |
+void InspectorController::registerModuleAgent(PassOwnPtrWillBeRawPtr<InspectorAgent> agent) |
{ |
m_moduleAgents.append(agent.get()); |
- m_agents.append(agent); |
+ agents().append(agent); |
} |
void InspectorController::setInspectorFrontendClient(PassOwnPtr<InspectorFrontendClient> inspectorFrontendClient) |
@@ -217,7 +232,7 @@ void InspectorController::connectFrontend(InspectorFrontendChannel* frontendChan |
// We can reconnect to existing front-end -> unmute state. |
m_state->unmute(); |
- m_agents.setFrontend(m_inspectorFrontend.get()); |
+ agents().setFrontend(m_inspectorFrontend.get()); |
InspectorInstrumentation::registerInstrumentingAgents(m_instrumentingAgents.get()); |
InspectorInstrumentation::frontendCreated(); |
@@ -225,7 +240,7 @@ void InspectorController::connectFrontend(InspectorFrontendChannel* frontendChan |
ASSERT(m_inspectorClient); |
m_inspectorBackendDispatcher = InspectorBackendDispatcher::create(frontendChannel); |
- m_agents.registerInDispatcher(m_inspectorBackendDispatcher.get()); |
+ agents().registerInDispatcher(m_inspectorBackendDispatcher.get()); |
} |
void InspectorController::disconnectFrontend() |
@@ -239,7 +254,7 @@ void InspectorController::disconnectFrontend() |
// Pre-disconnect state will be used to restore inspector agents. |
m_state->mute(); |
- m_agents.clearFrontend(); |
+ agents().clearFrontend(); |
m_inspectorFrontend.clear(); |
@@ -263,7 +278,7 @@ void InspectorController::reuseFrontend(InspectorFrontendChannel* frontendChanne |
ASSERT(!m_inspectorFrontend); |
connectFrontend(frontendChannel); |
m_state->loadFromCookie(inspectorStateCookie); |
- m_agents.restore(); |
+ agents().restore(); |
} |
void InspectorController::setProcessId(long processId) |
@@ -414,12 +429,12 @@ void InspectorController::didProcessTask() |
void InspectorController::flushPendingFrontendMessages() |
{ |
- m_agents.flushPendingFrontendMessages(); |
+ agents().flushPendingFrontendMessages(); |
} |
void InspectorController::didCommitLoadForMainFrame() |
{ |
- Vector<InspectorAgent*> agents = m_moduleAgents; |
+ WillBeHeapVector<RawPtrWillBeMember<InspectorAgent> > agents = m_moduleAgents; |
for (size_t i = 0; i < agents.size(); i++) |
agents[i]->didCommitLoadForMainFrame(); |
} |