Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: Source/modules/geolocation/GeolocationInspectorAgent.h

Issue 307943002: Oilpan: Prepare moving InspectorController and InspectorAgents to oilpan. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/geolocation/GeolocationInspectorAgent.h
diff --git a/Source/modules/geolocation/GeolocationInspectorAgent.h b/Source/modules/geolocation/GeolocationInspectorAgent.h
index 429ceae6167b378911e4ed545dff6c1fc6dbbb0d..0198bee122aba8c06899ce6b56aff8c753459426 100644
--- a/Source/modules/geolocation/GeolocationInspectorAgent.h
+++ b/Source/modules/geolocation/GeolocationInspectorAgent.h
@@ -46,8 +46,9 @@ typedef String ErrorString;
class GeolocationInspectorAgent FINAL : public InspectorBaseAgent<GeolocationInspectorAgent>, public InspectorBackendDispatcher::GeolocationCommandHandler {
WTF_MAKE_NONCOPYABLE(GeolocationInspectorAgent);
public:
- static PassOwnPtr<GeolocationInspectorAgent> create();
+ static PassOwnPtrWillBeRawPtr<GeolocationInspectorAgent> create();
virtual ~GeolocationInspectorAgent();
+ virtual void trace(Visitor*) OVERRIDE;
// Protocol methods.
virtual void setGeolocationOverride(ErrorString*, const double*, const double*, const double*) OVERRIDE;
@@ -56,16 +57,16 @@ public:
// Instrumentation method.
GeolocationPosition* overrideGeolocationPosition(GeolocationPosition*);
- void AddController(GeolocationController*);
- void RemoveController(GeolocationController*);
+ void addController(GeolocationController*);
+ void removeController(GeolocationController*);
private:
GeolocationInspectorAgent();
typedef WillBeHeapHashSet<RawPtrWillBeMember<GeolocationController> > GeolocationControllers;
- WillBePersistentHeapHashSet<RawPtrWillBeMember<GeolocationController> > m_controllers;
+ WillBeHeapHashSet<RawPtrWillBeMember<GeolocationController> > m_controllers;
haraken 2014/06/17 14:06:18 You can use GeoLocationControllers.
keishi 2014/06/18 12:31:07 Done.
bool m_geolocationOverridden;
- Persistent<GeolocationPosition> m_geolocationPosition;
- Persistent<GeolocationPosition> m_platformGeolocationPosition;
+ PersistentWillBeMember<GeolocationPosition> m_geolocationPosition;
+ PersistentWillBeMember<GeolocationPosition> m_platformGeolocationPosition;
};

Powered by Google App Engine
This is Rietveld 408576698