Oilpan: Prepare moving InspectorController and InspectorAgents to oilpan.

Source/core/inspector/InspectorInspectorAgent.cpp

Index: Source/core/inspector/InspectorInspectorAgent.cpp
diff --git a/Source/core/inspector/InspectorInspectorAgent.cpp b/Source/core/inspector/InspectorInspectorAgent.cpp
index 15eb17cdb21aded978075fecb543b58b7dc3e8a6..89795c0ae812febe1d873bfda386b33530a98157 100644
--- a/Source/core/inspector/InspectorInspectorAgent.cpp
+++ b/Source/core/inspector/InspectorInspectorAgent.cpp
@@ -63,7 +63,15 @@ InspectorInspectorAgent::InspectorInspectorAgent(Page* page, InjectedScriptManag
 
 InspectorInspectorAgent::~InspectorInspectorAgent()
 {
+#if !ENABLE(OILPAN)
     m_instrumentingAgents->setInspectorInspectorAgent(0);

[Mads Ager (chromium), 2014/06/11 06:20:48]

The lifetime is not completely clear to me here. m_instrumentingAgents is a raw
pointer to an InstrumentingAgents object which holds a raw pointer back to this
InspectorInspectorAgent. Are we guaranteed that the InspectorInspectorAgent and
the InstrumentingAgents will live and die together so that we do not have to
clear the pointer here? It seems to me that we would have to move
InstrumentingAgents to the heap as well and trace in both directions if they are
supposed to live and die together or use weak pointers to perform the clearing
if needed?

[keishi, 2014/06/11 14:10:53]

I've confirmed that InstrumentingAgents does not outlive InspectorController
when running LayoutTests but I'm not sure we can guarantee that completely so
I'm moving InstrumentingAgents to the heap in this patch.

+#endif
+}
+
+void InspectorInspectorAgent::trace(Visitor* visitor)
+{
+    visitor->trace(m_inspectedPage);
+    InspectorBaseAgent::trace(visitor);
 }
 
 void InspectorInspectorAgent::didClearDocumentOfWindowObject(LocalFrame* frame)