Oilpan: Prepare moving InspectorController and InspectorAgents to oilpan.

Source/core/workers/WorkerGlobalScope.cpp

 /*
  * Copyright (C) 2008 Apple Inc. All Rights Reserved.
  * Copyright (C) 2009, 2011 Google Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 61 matching lines @@
     }
 
     virtual bool isCleanupTask() const { return true; }
 };
 
 WorkerGlobalScope::WorkerGlobalScope(const KURL& url, const String& userAgent, WorkerThread* thread, double timeOrigin, PassOwnPtrWillBeRawPtr<WorkerClients> workerClients)
     : m_url(url)
     , m_userAgent(userAgent)
     , m_script(adoptPtr(new WorkerScriptController(*this)))
     , m_thread(thread)
-    , m_workerInspectorController(adoptPtr(new WorkerInspectorController(this)))
+    , m_workerInspectorController(adoptPtrWillBeNoop(new WorkerInspectorController(this)))
     , m_closing(false)
     , m_eventQueue(WorkerEventQueue::create(this))
     , m_workerClients(workerClients)
     , m_timeOrigin(timeOrigin)
     , m_terminationObserver(0)
 {
     ScriptWrappable::init(this);
     setClient(this);
     setSecurityOrigin(SecurityOrigin::create(url));
     m_workerClients->reattachThread();
@@ skipping 82 matching lines @@
     return m_navigator.get();
 }
 
 void WorkerGlobalScope::postTask(PassOwnPtr<ExecutionContextTask> task)
 {
     thread()->runLoop().postTask(task);
 }
 
 void WorkerGlobalScope::clearInspector()
 {
+    if (!m_workerInspectorController)

[haraken, 2014/06/12 08:40:25]

Is it possible that clearInspector() is called twice?

[keishi, 2014/06/13 03:37:34]

Seems like its called twice.

First from 
1   0x9e645cf WebCore::WorkerGlobalScope::clearInspector()
2   0x9e81e80
WebCore::WorkerThreadShutdownFinishTask::performTask(WebCore::ExecutionContext*)
3   0x9e793ca WebCore::WorkerRunLoopTask::run()
4   0x9e75d1a WebCore::WorkerRunLoop::runCleanupTasks()
5   0x9e753c0 WebCore::WorkerRunLoop::run()
6   0x9e7c881 WebCore::WorkerThread::runEventLoop()
7   0x9e55487 WebCore::DedicatedWorkerThread::runEventLoop()
8   0x9e7c775 WebCore::WorkerThread::workerThread()
9   0x9e7c3db WebCore::WorkerThread::workerThreadStart(void*)
10  0x17d82c77 WTF::threadEntryPoint(void*)
11  0x17d8350f WTF::wtfThreadEntryPoint(void*)
12  0x982c45fb _pthread_body
13  0x982c4485 _pthread_struct_init
14  0x982c9cf2 thread_start

And then from
1   0x9e3759e WebCore::WorkerGlobalScope::clearInspector()
2   0x9e37a13 WebCore::WorkerGlobalScope::dispose()
3   0x9e4f78f WebCore::WorkerThread::workerThread()
4   0x9e4f3bb WebCore::WorkerThread::workerThreadStart(void*)
5   0x17d5bc77 WTF::threadEntryPoint(void*)
6   0x17d5c50f WTF::wtfThreadEntryPoint(void*)
7   0x982c45fb _pthread_body
8   0x982c4485 _pthread_struct_init
9   0x982c9cf2 thread_start

[haraken, 2014/06/13 08:02:53]

Thanks, understood. It seems strange that clearInspector() is called twice, but
it's not related to your CL. I'll take a look.

[keishi, 2014/06/17 03:13:22]

Yes I think we can remove the call to clearInspector in
WorkerThreadShutdownFinishTask but I won't do it in this CL.

+        return;
+    m_workerInspectorController->discard();

[haraken, 2014/06/12 08:40:25]

We conventionally call this kind of method dispose().

[keishi, 2014/06/13 03:37:34]

Done.

     m_workerInspectorController.clear();
 }
 
 void WorkerGlobalScope::registerTerminationObserver(TerminationObserver* observer)
 {
     ASSERT(!m_terminationObserver);
     ASSERT(observer);
     m_terminationObserver = observer;
 }
 
@@ skipping 124 matching lines @@
 WorkerEventQueue* WorkerGlobalScope::eventQueue() const
 {
     return m_eventQueue.get();
 }
 
 void WorkerGlobalScope::trace(Visitor* visitor)
 {
     visitor->trace(m_console);
     visitor->trace(m_location);
     visitor->trace(m_navigator);
+    visitor->trace(m_workerInspectorController);
     visitor->trace(m_eventQueue);
     visitor->trace(m_workerClients);
     WillBeHeapSupplementable<WorkerGlobalScope>::trace(visitor);
     ExecutionContext::trace(visitor);
     EventTargetWithInlineData::trace(visitor);
 }
 
 } // namespace WebCore