Oilpan: Prepare moving InspectorController and InspectorAgents to oilpan.

Source/core/inspector/InspectorInspectorAgent.cpp

 /*
  * Copyright (C) 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Matt Lilek <webkit@mattlilek.com>
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 45 matching lines @@
     : InspectorBaseAgent<InspectorInspectorAgent>("Inspector")
     , m_inspectedPage(page)
     , m_frontend(0)
     , m_injectedScriptManager(injectedScriptManager)
 {
     ASSERT_ARG(page, page);
 }
 
 InspectorInspectorAgent::~InspectorInspectorAgent()
 {
+#if !ENABLE(OILPAN)
     m_instrumentingAgents->setInspectorInspectorAgent(0);

[Mads Ager (chromium), 2014/06/11 06:20:48]

The lifetime is not completely clear to me here. m_instrumentingAgents is a raw
pointer to an InstrumentingAgents object which holds a raw pointer back to this
InspectorInspectorAgent. Are we guaranteed that the InspectorInspectorAgent and
the InstrumentingAgents will live and die together so that we do not have to
clear the pointer here? It seems to me that we would have to move
InstrumentingAgents to the heap as well and trace in both directions if they are
supposed to live and die together or use weak pointers to perform the clearing
if needed?

[keishi, 2014/06/11 14:10:53]

I've confirmed that InstrumentingAgents does not outlive InspectorController
when running LayoutTests but I'm not sure we can guarantee that completely so
I'm moving InstrumentingAgents to the heap in this patch.

+#endif
+}
+
+void InspectorInspectorAgent::trace(Visitor* visitor)
+{
+    visitor->trace(m_inspectedPage);
+    InspectorBaseAgent::trace(visitor);
 }
 
 void InspectorInspectorAgent::didClearDocumentOfWindowObject(LocalFrame* frame)
 {
     if (m_injectedScriptForOrigin.isEmpty())
         return;
 
     String origin = frame->document()->securityOrigin()->toRawString();
     String script = m_injectedScriptForOrigin.get(origin);
     if (script.isEmpty())
@@ skipping 75 matching lines @@
         m_frontend->inspector()->inspect(objectToInspect, hints);
         m_pendingInspectData.first = nullptr;
         m_pendingInspectData.second = nullptr;
         return;
     }
     m_pendingInspectData.first = objectToInspect;
     m_pendingInspectData.second = hints;
 }
 
 } // namespace WebCore