Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Issue 307933008: Revert 273866 "Block content scripts from executing until user g..." (Closed)

Created:
6 years, 6 months ago by dxie1
Modified:
6 years, 6 months ago
Reviewers:
Devlin
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 273866 "Block content scripts from executing until user g..." Referring to https://code.google.com/p/chromium/issues/detail?id=379472, This is causing significant stability on trunk. Reverting. > Block content scripts from executing until user grants permission > > Prevent extensions with <all_urls> from running content scripts without user > consent if the scripts-require-action switch is on. > > BUG=362353 > > Review URL: https://codereview.chromium.org/288053002 TBR=rdevlin.cronin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274102

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -480 lines) Patch
M trunk/src/chrome/browser/chrome_content_browser_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/extensions/active_script_controller.h View 2 chunks +4 lines, -8 lines 0 comments Download
M trunk/src/chrome/browser/extensions/active_script_controller.cc View 3 chunks +10 lines, -37 lines 0 comments Download
M trunk/src/chrome/browser/extensions/active_script_controller_browsertest.cc View 7 chunks +10 lines, -55 lines 0 comments Download
M trunk/src/chrome/browser/extensions/user_script_master.h View 2 chunks +2 lines, -10 lines 0 comments Download
M trunk/src/chrome/browser/extensions/user_script_master.cc View 6 chunks +7 lines, -19 lines 0 comments Download
M trunk/src/extensions/common/extension_messages.h View 2 chunks +4 lines, -19 lines 0 comments Download
M trunk/src/extensions/common/permissions/permissions_data.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M trunk/src/extensions/common/user_script.h View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/extensions/renderer/dispatcher.h View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/extensions/renderer/dispatcher.cc View 1 chunk +3 lines, -18 lines 0 comments Download
M trunk/src/extensions/renderer/extension_helper.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/extensions/renderer/extension_helper.cc View 3 chunks +1 line, -10 lines 0 comments Download
M trunk/src/extensions/renderer/script_injection.h View 5 chunks +8 lines, -43 lines 0 comments Download
M trunk/src/extensions/renderer/script_injection.cc View 4 chunks +0 lines, -151 lines 0 comments Download
M trunk/src/extensions/renderer/user_script_slave.h View 2 chunks +1 line, -13 lines 0 comments Download
M trunk/src/extensions/renderer/user_script_slave.cc View 6 chunks +44 lines, -87 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dxie1
6 years, 6 months ago (2014-06-01 02:15:45 UTC) #1
dxie1
6 years, 6 months ago (2014-06-01 02:16:48 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r274102 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698