Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Issue 307933007: Cast: Log audio received events for audio (Closed)

Created:
6 years, 6 months ago by Alpha Left Google
Modified:
6 years, 6 months ago
Reviewers:
imcheng, hubbe, miu
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Visibility:
Public.

Description

Cast: Log audio received events for audio Audio ACK received events are important for simulation. Logging it now. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274018

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M media/cast/audio_sender/audio_sender.h View 1 chunk +4 lines, -0 lines 1 comment Download
M media/cast/audio_sender/audio_sender.cc View 3 chunks +10 lines, -2 lines 0 comments Download
M media/cast/test/end2end_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Alpha Left Google
6 years, 6 months ago (2014-05-30 19:29:30 UTC) #1
imcheng
lgtm
6 years, 6 months ago (2014-05-30 20:26:02 UTC) #2
Alpha Left Google
The CQ bit was checked by hclam@chromium.org
6 years, 6 months ago (2014-05-30 20:37:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/307933007/1
6 years, 6 months ago (2014-05-30 20:39:06 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-30 20:39:07 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-05-30 20:39:08 UTC) #6
Alpha Left Google
6 years, 6 months ago (2014-05-30 20:42:14 UTC) #7
Alpha Left Google
6 years, 6 months ago (2014-05-30 23:00:52 UTC) #8
hubbe
lgtm
6 years, 6 months ago (2014-05-30 23:31:07 UTC) #9
Alpha Left Google
The CQ bit was checked by hclam@chromium.org
6 years, 6 months ago (2014-05-30 23:31:29 UTC) #10
miu
lgtm https://codereview.chromium.org/307933007/diff/1/media/cast/audio_sender/audio_sender.h File media/cast/audio_sender/audio_sender.h (right): https://codereview.chromium.org/307933007/diff/1/media/cast/audio_sender/audio_sender.h#newcode71 media/cast/audio_sender/audio_sender.h:71: RtpTimestamp frame_id_to_rtp_timestamp_[256]; Ugh. I hate this approach. But, ...
6 years, 6 months ago (2014-05-30 23:33:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hclam@chromium.org/307933007/1
6 years, 6 months ago (2014-05-30 23:36:45 UTC) #12
commit-bot: I haz the power
6 years, 6 months ago (2014-05-31 04:34:32 UTC) #13
Message was sent while issue was closed.
Change committed as 274018

Powered by Google App Engine
This is Rietveld 408576698