Issue 307903002: X87: Refactor HType to get rid of various hacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 307903002: X87: Refactor HType to get rid of various hacks. (Closed)

Created:
6 years, 6 months ago by Weiliang

Modified:
6 years, 6 months ago

Reviewers:
Benedikt Meurer, danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

X87: Refactor HType to get rid of various hacks. port r21578 (dcf13aa) Original commit message: - Move HType to it's own file. - Add HType::HeapObject and some other useful types. - Get rid of the broken and useless HType::NonPrimitive. - Introduce HType::FromType() to convert from HeapType to HType. - Also add unit tests for HType. - Fix types in Crankshaft. BUG= Committed: https://code.google.com/p/v8/source/detail?r=21579

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -7 lines)			Patch
	M	src/x87/lithium-codegen-x87.cc	View		6 chunks	+6 lines, -6 lines	0 comments	Download
	M	src/x87/lithium-x87.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Weiliang

6 years, 6 months ago (2014-05-29 13:12:07 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r21579 (presubmit successful).

Expand Messages | Collapse Messages