Generate missing "block.ReThrow();" before return

Generate missing "block.ReThrow();" before return

After r174546 a v8::TryCatch object is in scope when calling a method's
C++ implementation early due to missing optional arguments.  If the
implementation throws an exception, we need to call ReThrow() on that
v8::TryCatch object for the exception to be propagated correctly.

BUG=362388
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175076

[haraken, 2014-05-29 05:24:50]

LGTM

[Jens Widell, 2014-05-29 05:25:48]

The CQ bit was checked by jl@opera.com

[commit-bot: I haz the power, 2014-05-29 05:26:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jl@opera.com/307883002/1

[yhirano, 2014-05-29 05:31:06]

Can you put block.ReThrow in throw_from_exception_state macro (perhaps you have
to introduce has_outer_trycatch parameter to the macro)?
That makes me happy because I'm implementing Promise execution handling at
https://codereview.chromium.org/232563003/ .

[Jens Widell, 2014-05-29 05:55:04]

The CQ bit was unchecked by jl@opera.com

[Jens Widell, 2014-05-29 06:00:54]

On 2014/05/29 05:31:06, yhirano wrote:
> Can you put block.ReThrow in throw_from_exception_state macro (perhaps you
have
> to introduce has_outer_trycatch parameter to the macro)?
> That makes me happy because I'm implementing Promise execution handling at
> https://codereview.chromium.org/232563003/ .

Done is patch set 2. Does that look good to you?

[yhirano, 2014-05-29 06:12:40]

thanks, LGTM

[Jens Widell, 2014-05-29 06:13:51]

The CQ bit was checked by jl@opera.com

[commit-bot: I haz the power, 2014-05-29 06:14:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jl@opera.com/307883002/10001

[commit-bot: I haz the power, 2014-05-29 07:29:40]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/9918)

[commit-bot: I haz the power, 2014-05-30 00:29:50]

Change committed as 175076