Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1376)

Issue 307883002: Generate missing "block.ReThrow();" before return (Closed)

Created:
6 years, 6 months ago by Jens Widell
Modified:
6 years, 6 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Generate missing "block.ReThrow();" before return After r174546 a v8::TryCatch object is in scope when calling a method's C++ implementation early due to missing optional arguments. If the implementation throws an exception, we need to call ReThrow() on that v8::TryCatch object for the exception to be propagated correctly. BUG=362388 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175076

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -13 lines) Patch
M Source/bindings/templates/methods.cpp View 1 7 chunks +18 lines, -13 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Jens Widell
6 years, 6 months ago (2014-05-29 05:19:38 UTC) #1
haraken
LGTM
6 years, 6 months ago (2014-05-29 05:24:50 UTC) #2
Jens Widell
The CQ bit was checked by jl@opera.com
6 years, 6 months ago (2014-05-29 05:25:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/307883002/1
6 years, 6 months ago (2014-05-29 05:26:13 UTC) #4
yhirano
Can you put block.ReThrow in throw_from_exception_state macro (perhaps you have to introduce has_outer_trycatch parameter to ...
6 years, 6 months ago (2014-05-29 05:31:06 UTC) #5
Jens Widell
The CQ bit was unchecked by jl@opera.com
6 years, 6 months ago (2014-05-29 05:55:04 UTC) #6
Jens Widell
On 2014/05/29 05:31:06, yhirano wrote: > Can you put block.ReThrow in throw_from_exception_state macro (perhaps you ...
6 years, 6 months ago (2014-05-29 06:00:54 UTC) #7
yhirano
thanks, LGTM
6 years, 6 months ago (2014-05-29 06:12:40 UTC) #8
Jens Widell
The CQ bit was checked by jl@opera.com
6 years, 6 months ago (2014-05-29 06:13:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jl@opera.com/307883002/10001
6 years, 6 months ago (2014-05-29 06:14:19 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-05-29 07:29:40 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 00:29:50 UTC) #12
Message was sent while issue was closed.
Change committed as 175076

Powered by Google App Engine
This is Rietveld 408576698