Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3524)

Unified Diff: chrome/browser/ui/views/create_application_shortcut_view.h

Issue 307873002: Removed the App Info information from the Create App Shortcuts dialog (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review feedback Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/create_application_shortcut_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/create_application_shortcut_view.h
diff --git a/chrome/browser/ui/views/create_application_shortcut_view.h b/chrome/browser/ui/views/create_application_shortcut_view.h
index 7a503258ad6246841876ac43b54e5099c6d2f2f9..9d70eeef6d26bfc379b1a5ef382443cd62b4410b 100644
--- a/chrome/browser/ui/views/create_application_shortcut_view.h
+++ b/chrome/browser/ui/views/create_application_shortcut_view.h
@@ -40,11 +40,21 @@ class Label;
class CreateApplicationShortcutView : public views::DialogDelegateView,
public views::ButtonListener {
public:
+ enum DialogLayout {
+ // URL shortcuts have an info frame at the top with a thumbnail, title and
+ // description.
+ DIALOG_LAYOUT_URL_SHORTCUT,
+
+ // App shortcuts don't have an info frame, since they are launched from
+ // places where it's clear what app they are from.
+ DIALOG_LAYOUT_APP_SHORTCUT
+ };
+
explicit CreateApplicationShortcutView(Profile* profile);
virtual ~CreateApplicationShortcutView();
// Initialize the controls on the dialog.
- void InitControls();
+ void InitControls(DialogLayout dialog_layout);
// Overridden from views::View:
virtual gfx::Size GetPreferredSize() const OVERRIDE;
@@ -69,6 +79,7 @@ class CreateApplicationShortcutView : public views::DialogDelegateView,
Profile* profile_;
// UI elements on the dialog.
+ // May be NULL if we are not displaying the app's info.
views::View* app_info_;
views::Label* create_shortcuts_label_;
views::Checkbox* desktop_check_box_;
@@ -132,9 +143,6 @@ class CreateChromeApplicationShortcutView
virtual bool Cancel() OVERRIDE;
private:
- void OnShortcutInfoLoaded(
- const web_app::ShortcutInfo& shortcut_info);
-
base::Callback<void(bool)> close_callback_;
base::WeakPtrFactory<CreateChromeApplicationShortcutView> weak_ptr_factory_;
« no previous file with comments | « no previous file | chrome/browser/ui/views/create_application_shortcut_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698