Always set NSTexturedBackgroundWindowMask on app windows.

Always set NSTexturedBackgroundWindowMask on app windows.

This is consistent with FramedBrowserWindow.

This also skips drawing the frame of frameless windows.

On OSX 10.7, if NSTexturedBackgroundWindowMask is set, NSGrayFrame is
used to draw the frame. If not, NSThemeFrame is used. Since we swizzle
drawing methods on NSGrayFrame on 10.7, the app windows should all use
NSGrayFrame.

BUG=378581
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273781

[tapted, 2014-05-29 03:35:28]

lgtm

https://codereview.chromium.org/307843002/diff/1/chrome/browser/ui/cocoa/apps...
File chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm (right):

https://codereview.chromium.org/307843002/diff/1/chrome/browser/ui/cocoa/apps...
chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm:250: -
(void)drawCustomFrameRect:(NSRect)rect forView:(NSView*)view;
I'd move this up into the ShellNSWindow interface (and move empty implementation
into ShellNSWindow implementation). Then ShellCustomFrameNSWindow overrides it.
Feels more natural than just happening to have the same method implemented on
both child classes :)

https://codereview.chromium.org/307843002/diff/1/chrome/browser/ui/cocoa/apps...
chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm:377:
NSTexturedBackgroundWindowMask;
The documentation suggests that adding this has a side-effect of "always"
drawing the window with rounded corners.. but I guess that's fine since I don't
think there's a way for a packaged app to have square corners currently if they
wanted to..

[jackhou1, 2014-05-29 04:09:39]

https://codereview.chromium.org/307843002/diff/1/chrome/browser/ui/cocoa/apps...
File chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm (right):

https://codereview.chromium.org/307843002/diff/1/chrome/browser/ui/cocoa/apps...
chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm:250: -
(void)drawCustomFrameRect:(NSRect)rect forView:(NSView*)view;
On 2014/05/29 03:35:28, tapted wrote:
> I'd move this up into the ShellNSWindow interface (and move empty
implementation
> into ShellNSWindow implementation). Then ShellCustomFrameNSWindow overrides
it.
> Feels more natural than just happening to have the same method implemented on
> both child classes :)

ShellNSWindow is used to draw native frames, so it needs to call the default
implementation.

https://codereview.chromium.org/307843002/diff/1/chrome/browser/ui/cocoa/apps...
chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm:377:
NSTexturedBackgroundWindowMask;
On 2014/05/29 03:35:28, tapted wrote:
> The documentation suggests that adding this has a side-effect of "always"
> drawing the window with rounded corners.. but I guess that's fine since I
don't
> think there's a way for a packaged app to have square corners currently if
they
> wanted to..

Yeah, and I think this only applies for native frames. I.e. we can still make
ShellCustomFrameNSWindow draw whatever we want. That said,
ShellFramelessNSWindow seems to have rounded bottom corners regardless of
whether this is set.

[jackhou1, 2014-05-29 04:09:58]

The CQ bit was checked by jackhou@chromium.org

[commit-bot: I haz the power, 2014-05-29 04:11:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jackhou@chromium.org/307843002/1

[jackhou1, 2014-05-29 05:12:47]

The CQ bit was unchecked by jackhou@chromium.org

[jackhou1, 2014-05-29 05:15:11]

The CQ bit was checked by jackhou@chromium.org

[commit-bot: I haz the power, 2014-05-29 05:15:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jackhou@chromium.org/307843002/20001

[commit-bot: I haz the power, 2014-05-29 08:26:35]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-05-29 09:06:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-29 09:06:18]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[jackhou1, 2014-05-30 00:42:55]

The CQ bit was checked by jackhou@chromium.org

[commit-bot: I haz the power, 2014-05-30 00:45:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jackhou@chromium.org/307843002/20001

[commit-bot: I haz the power, 2014-05-30 01:04:05]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-05-30 02:27:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-30 02:27:44]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[jackhou1, 2014-05-30 03:49:20]

The CQ bit was checked by jackhou@chromium.org

[commit-bot: I haz the power, 2014-05-30 03:51:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jackhou@chromium.org/307843002/20001

[commit-bot: I haz the power, 2014-05-30 10:15:06]

Change committed as 273781