Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Unified Diff: pkg/template_binding/lib/src/input_bindings.dart

Issue 307793002: update polymer, nodebind, and templatebinding (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/template_binding/lib/src/element.dart ('k') | pkg/template_binding/lib/src/input_element.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/template_binding/lib/src/input_bindings.dart
diff --git a/pkg/template_binding/lib/src/input_bindings.dart b/pkg/template_binding/lib/src/input_bindings.dart
index 6292527d4b3ae3ffe588a116f94d5c3905c1bcc6..3cdc7db7bc70313e77873158de60bbd1dcaef32a 100644
--- a/pkg/template_binding/lib/src/input_bindings.dart
+++ b/pkg/template_binding/lib/src/input_bindings.dart
@@ -107,9 +107,12 @@ class _InputBinding extends Bindable {
case 'select-multiple':
case 'select-one':
return element.onChange;
- default:
- return element.onInput;
+ case 'range':
+ if (window.navigator.userAgent.contains(new RegExp('Trident|MSIE'))) {
+ return element.onChange;
+ }
}
+ return element.onInput;
}
// |element| is assumed to be an HTMLInputElement with |type| == 'radio'.
@@ -148,3 +151,17 @@ class _InputBinding extends Bindable {
return value is int ? value : 0;
}
}
+
+_getTreeScope(Node node) {
+ Node parent;
+ while ((parent = node.parentNode) != null ) {
+ node = parent;
+ }
+
+ return _hasGetElementById(node) ? node : null;
+}
+
+// Note: JS code tests that getElementById is present. We can't do that
+// easily, so instead check for the types known to implement it.
+bool _hasGetElementById(Node node) =>
+ node is Document || node is ShadowRoot || node is SvgSvgElement;
« no previous file with comments | « pkg/template_binding/lib/src/element.dart ('k') | pkg/template_binding/lib/src/input_element.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698