Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2343)

Unified Diff: chrome/browser/sync/profile_sync_components_factory_impl.cc

Issue 307783002: Instantiate AttachmentDownloader and use it in AttachmentServiceImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix components unittest Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/sync_driver/generic_change_processor_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/profile_sync_components_factory_impl.cc
diff --git a/chrome/browser/sync/profile_sync_components_factory_impl.cc b/chrome/browser/sync/profile_sync_components_factory_impl.cc
index 848272a6e6822f4d196edcc0231e23b8e397c623..57e720e7a3360cd5906fe0707d1b26dfac7c5036 100644
--- a/chrome/browser/sync/profile_sync_components_factory_impl.cc
+++ b/chrome/browser/sync/profile_sync_components_factory_impl.cc
@@ -61,6 +61,7 @@
#include "sync/api/attachments/attachment_service.h"
#include "sync/api/attachments/attachment_service_impl.h"
#include "sync/api/syncable_service.h"
+#include "sync/internal_api/public/attachments/fake_attachment_downloader.h"
#include "sync/internal_api/public/attachments/fake_attachment_store.h"
#include "sync/internal_api/public/attachments/fake_attachment_uploader.h"
@@ -569,19 +570,23 @@ base::WeakPtr<syncer::SyncableService> ProfileSyncComponentsFactoryImpl::
scoped_ptr<syncer::AttachmentService>
ProfileSyncComponentsFactoryImpl::CreateAttachmentService(
syncer::AttachmentService::Delegate* delegate) {
- // TODO(maniscalco): Use a shared (one per profile) thread-safe instance of
- // AttachmentUpload instead of creating a new one per AttachmentService (bug
- // 369536).
+ // TODO(maniscalco): Use a shared (one per profile) thread-safe instances of
+ // AttachmentUploader and AttachmentDownloader instead of creating a new one
+ // per AttachmentService (bug 369536).
scoped_ptr<syncer::AttachmentUploader> attachment_uploader(
new syncer::FakeAttachmentUploader);
+ scoped_ptr<syncer::AttachmentDownloader> attachment_downloader(
+ new syncer::FakeAttachmentDownloader());
scoped_ptr<syncer::AttachmentStore> attachment_store(
new syncer::FakeAttachmentStore(
BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE)));
scoped_ptr<syncer::AttachmentService> attachment_service(
- new syncer::AttachmentServiceImpl(
- attachment_store.Pass(), attachment_uploader.Pass(), delegate));
+ new syncer::AttachmentServiceImpl(attachment_store.Pass(),
+ attachment_uploader.Pass(),
+ attachment_downloader.Pass(),
+ delegate));
return attachment_service.Pass();
}
« no previous file with comments | « no previous file | components/sync_driver/generic_change_processor_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698