Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 307773005: Adding AsValue and TypeString methods to DelayBasedTimeSource. (Closed)

Created:
6 years, 6 months ago by mithro-old
Modified:
6 years, 6 months ago
Reviewers:
brianderson
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Adding AsValue and TypeString methods to DelayBasedTimeSource. This makes it possible to see the internal state of the time source for debugging purposes. BUG=371223 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276390

Patch Set 1 #

Patch Set 2 : Rebasing onto master. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -8 lines) Patch
M cc/scheduler/delay_based_time_source.h View 3 chunks +11 lines, -2 lines 0 comments Download
M cc/scheduler/delay_based_time_source.cc View 3 chunks +40 lines, -2 lines 0 comments Download
M cc/scheduler/scheduler.h View 1 2 chunks +4 lines, -2 lines 1 comment Download
M cc/scheduler/scheduler.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download
M cc/scheduler/time_source.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
mithro-old
Hi Brian, Another small CL split out from other work which adds support for better ...
6 years, 6 months ago (2014-05-29 02:40:53 UTC) #1
mithro-old
On 2014/05/29 at 02:40:53, mithro wrote: > Hi Brian, > > Another small CL split ...
6 years, 6 months ago (2014-06-10 02:48:33 UTC) #2
brianderson
lgtm https://codereview.chromium.org/307773005/diff/20001/cc/scheduler/scheduler.h File cc/scheduler/scheduler.h (left): https://codereview.chromium.org/307773005/diff/20001/cc/scheduler/scheduler.h#oldcode20 cc/scheduler/scheduler.h:20: #include "cc/scheduler/time_source.h" Can we just delete time_source.h? Seems ...
6 years, 6 months ago (2014-06-10 18:16:52 UTC) #3
mithro-old
The CQ bit was checked by mithro@mithis.com
6 years, 6 months ago (2014-06-11 02:03:22 UTC) #4
mithro-old
On 2014/06/10 at 18:16:52, brianderson wrote: > lgtm > > https://codereview.chromium.org/307773005/diff/20001/cc/scheduler/scheduler.h > File cc/scheduler/scheduler.h (left): ...
6 years, 6 months ago (2014-06-11 02:03:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mithro@mithis.com/307773005/20001
6 years, 6 months ago (2014-06-11 02:04:35 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 08:09:45 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 14:33:59 UTC) #8
Message was sent while issue was closed.
Change committed as 276390

Powered by Google App Engine
This is Rietveld 408576698