Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 307733003: Tiny fixes for reset screen A11y. (Closed)

Created:
6 years, 6 months ago by merkulova
Modified:
6 years, 6 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Tiny fixes for reset screen A11y. BUG=373275 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273777

Patch Set 1 #

Total comments: 2

Patch Set 2 : Uncommented back. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/resources/chromeos/login/oobe_screen_reset.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
merkulova
6 years, 6 months ago (2014-05-29 13:11:00 UTC) #1
dzhioev (left Google)
https://codereview.chromium.org/307733003/diff/1/chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc File chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc (right): https://codereview.chromium.org/307733003/diff/1/chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc#newcode267 chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc:267: // StartDeviceWipe(); Are you sure about these changes?
6 years, 6 months ago (2014-05-29 13:42:55 UTC) #2
merkulova
https://codereview.chromium.org/307733003/diff/1/chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc File chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc (right): https://codereview.chromium.org/307733003/diff/1/chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc#newcode267 chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc:267: // StartDeviceWipe(); On 2014/05/29 13:42:55, dzhioev wrote: > Are ...
6 years, 6 months ago (2014-05-29 13:47:52 UTC) #3
dzhioev (left Google)
On 2014/05/29 13:47:52, merkulova wrote: > https://codereview.chromium.org/307733003/diff/1/chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc > File chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc (right): > > https://codereview.chromium.org/307733003/diff/1/chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc#newcode267 > ...
6 years, 6 months ago (2014-05-29 14:31:28 UTC) #4
merkulova
The CQ bit was checked by merkulova@chromium.org
6 years, 6 months ago (2014-05-29 14:55:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/merkulova@chromium.org/307733003/20001
6 years, 6 months ago (2014-05-29 14:57:32 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-05-29 16:36:42 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-29 17:12:39 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/157996)
6 years, 6 months ago (2014-05-29 17:12:39 UTC) #9
merkulova
The CQ bit was checked by merkulova@chromium.org
6 years, 6 months ago (2014-05-29 20:09:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/merkulova@chromium.org/307733003/20001
6 years, 6 months ago (2014-05-29 20:11:23 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-05-29 20:51:12 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-29 21:35:44 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/157996)
6 years, 6 months ago (2014-05-29 21:35:44 UTC) #14
merkulova
The CQ bit was checked by merkulova@chromium.org
6 years, 6 months ago (2014-05-30 08:34:24 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/merkulova@chromium.org/307733003/20001
6 years, 6 months ago (2014-05-30 08:34:42 UTC) #16
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 10:06:11 UTC) #17
Message was sent while issue was closed. 
Change committed as 273777

Powered by Google App Engine
This is Rietveld 408576698