chrome/browser/extensions/extensions_ui.cc - Issue 3077022: Extension package creation cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extensions_ui.cc

Issue 3077022: Extension package creation cleanup (Closed) Base URL: http://src.chromium.org/git/chromium.git

Patch Set: This would be a lot easier if I could actually compile on Windows Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extensions_ui.cc

diff --git a/chrome/browser/extensions/extensions_ui.cc b/chrome/browser/extensions/extensions_ui.cc

index a26ab07d23f50c68f5c55ae12446ef9338800784..33952867062d1fa9031b2ca67b32b3291aafdb4e 100644

--- a/chrome/browser/extensions/extensions_ui.cc

+++ b/chrome/browser/extensions/extensions_ui.cc

@@ -628,18 +628,8 @@ void ExtensionsDOMHandler::HandlePackMessage(const Value* value) {

void ExtensionsDOMHandler::OnPackSuccess(const FilePath& crx_file,

const FilePath& pem_file) {

- std::string message;

- if (!pem_file.empty()) {

- message = l10n_util::GetStringFUTF8(

- IDS_EXTENSION_PACK_DIALOG_SUCCESS_BODY_NEW,

- WideToUTF16(crx_file.ToWStringHack()),

- WideToUTF16(pem_file.ToWStringHack()));

- } else {

- message = l10n_util::GetStringFUTF8(

- IDS_EXTENSION_PACK_DIALOG_SUCCESS_BODY_UPDATE,

- WideToUTF16(crx_file.ToWStringHack()));

- }

- ShowAlert(message);

+ ShowAlert(WideToUTF8(PackExtensionJob::StandardSuccessMessage(crx_file,

+ pem_file)));

ListValue results;

dom_ui_->CallJavascriptFunction(L"hidePackDialog", results);