Extension package creation cleanup

chrome/browser/extensions/extensions_ui.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extensions_ui.h"
 
 #include "app/l10n_util.h"
 #include "app/resource_bundle.h"
 #include "base/base64.h"
 #include "base/callback.h"
@@ skipping 608 matching lines @@
     return;
   }
 
   pack_job_ = new PackExtensionJob(this, root_directory, key_file);
   pack_job_->Start();
 }
 
 void ExtensionsDOMHandler::OnPackSuccess(const FilePath& crx_file,
                                          const FilePath& pem_file) {
   std::string message;
+  // TODO we probably shouldn't use ToWStringHack() -- what's the right thing to
+  //      do?
   if (!pem_file.empty()) {
     message = WideToUTF8(l10n_util::GetStringF(
         IDS_EXTENSION_PACK_DIALOG_SUCCESS_BODY_NEW,
         crx_file.ToWStringHack(),
         pem_file.ToWStringHack()));
   } else {
     message = WideToUTF8(l10n_util::GetStringF(
         IDS_EXTENSION_PACK_DIALOG_SUCCESS_BODY_UPDATE,
         crx_file.ToWStringHack()));
   }
   ShowAlert(message);
 
   ListValue results;
   dom_ui_->CallJavascriptFunction(L"hidePackDialog", results);
 }
 
-void ExtensionsDOMHandler::OnPackFailure(const std::wstring& error) {
-  ShowAlert(WideToUTF8(error));
+void ExtensionsDOMHandler::OnPackFailure(const std::string& error) {
+  ShowAlert(error);
 }
 
 void ExtensionsDOMHandler::HandleAutoUpdateMessage(const Value* value) {
   ExtensionUpdater* updater = extensions_service_->updater();
   if (updater) {
     updater->CheckNow();
   }
 }
 
 void ExtensionsDOMHandler::HandleSelectFilePathMessage(const Value* value) {
@@ skipping 286 matching lines @@
 // static
 RefCountedMemory* ExtensionsUI::GetFaviconResourceBytes() {
   return ResourceBundle::GetSharedInstance().
       LoadDataResourceBytes(IDR_PLUGIN);
 }
 
 // static
 void ExtensionsUI::RegisterUserPrefs(PrefService* prefs) {
   prefs->RegisterBooleanPref(prefs::kExtensionsUIDeveloperMode, false);
 }