ipc/ipc_test_base.cc - Issue 307653003: Introduce IPC::Channel::Create*() to ensure it being heap-allocated.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/ipc_test_base.cc

Issue 307653003: Introduce IPC::Channel::Create*() to ensure it being heap-allocated. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixing windows build, landing again. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ipc/ipc_test_base.cc

diff --git a/ipc/ipc_test_base.cc b/ipc/ipc_test_base.cc

index b609e8cb2c23fecd6c9b338834b8fafbfb54f8b8..ca45d16de30df7207c328cfe5fe61e64f7476898 100644

--- a/ipc/ipc_test_base.cc

+++ b/ipc/ipc_test_base.cc

@@ -69,9 +69,7 @@ void IPCTestBase::CreateChannelFromChannelHandle(

IPC::Listener* listener) {

CHECK(!channel_.get());

CHECK(!channel_proxy_.get());

- channel_.reset(new IPC::Channel(channel_handle,

- IPC::Channel::MODE_SERVER,

- listener));

+ channel_ = IPC::Channel::CreateServer(channel_handle, listener);

}

void IPCTestBase::CreateChannelProxy(

« no previous file with comments | « ipc/ipc_send_fds_test.cc ('k') | ipc/sync_socket_unittest.cc » ('j') | no next file with comments »