Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Unified Diff: ipc/ipc_channel_common.cc

Issue 307653003: Introduce IPC::Channel::Create*() to ensure it being heap-allocated. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ipc/ipc_channel_common.cc
diff --git a/ipc/ipc_channel_common.cc b/ipc/ipc_channel_common.cc
new file mode 100644
index 0000000000000000000000000000000000000000..8be0f114042e67164a45963463f3dddf449724ad
--- /dev/null
+++ b/ipc/ipc_channel_common.cc
@@ -0,0 +1,52 @@
+// Copyright (c) 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ipc/ipc_channel.h"
+
+namespace IPC {
+
+// static
+Channel* Channel::CreateByModeForProxy(
+ const IPC::ChannelHandle &channel_handle, Mode mode, Listener* listener) {
+ return new Channel(channel_handle, mode, listener);
+}
+
+// static
+Channel* Channel::CreateClient(
+ const IPC::ChannelHandle &channel_handle, Listener* listener) {
+ return new Channel(channel_handle, Channel::MODE_CLIENT, listener);
+}
+
+// static
+Channel* Channel::CreateNamedServer(
+ const IPC::ChannelHandle &channel_handle, Listener* listener) {
+ return new Channel(channel_handle, Channel::MODE_NAMED_SERVER, listener);
+}
+
+// static
+Channel* Channel::CreateNamedClient(
+ const IPC::ChannelHandle &channel_handle, Listener* listener) {
+ return new Channel(channel_handle, Channel::MODE_NAMED_CLIENT, listener);
+}
+
+// static
+Channel* Channel::CreateOpenNamedServer(
+ const IPC::ChannelHandle &channel_handle, Listener* listener) {
+#if defined(OS_POSIX)
+ return new Channel(channel_handle, Channel::MODE_OPEN_NAMED_SERVER, listener);
+#else
+ NOTIMPLEMENTED();
+ return NULL;
+#endif
+}
+
+// static
+Channel* Channel::CreateServer(
+ const IPC::ChannelHandle &channel_handle, Listener* listener) {
+ return new Channel(channel_handle, Channel::MODE_SERVER, listener);
+}
+
+
+} // namespace IPC
+
« ipc/ipc_channel.h ('K') | « ipc/ipc_channel.h ('k') | ipc/ipc_channel_posix_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698