Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Side by Side Diff: ipc/ipc_channel_unittest.cc

Issue 307653003: Introduce IPC::Channel::Create*() to ensure it being heap-allocated. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixing windows build, landing again. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « ipc/ipc_channel_proxy_unittest.cc ('k') | ipc/ipc_fuzzing_tests.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "build/build_config.h" 5 #include "build/build_config.h"
6 6
7 #if defined(OS_WIN) 7 #if defined(OS_WIN)
8 #include <windows.h> 8 #include <windows.h>
9 #endif 9 #endif
10 10
(...skipping 236 matching lines...) Expand 10 before | Expand all | Expand 10 after
247 247
248 EXPECT_TRUE(WaitForClientShutdown()); 248 EXPECT_TRUE(WaitForClientShutdown());
249 DestroyChannel(); 249 DestroyChannel();
250 } 250 }
251 251
252 MULTIPROCESS_IPC_TEST_CLIENT_MAIN(GenericClient) { 252 MULTIPROCESS_IPC_TEST_CLIENT_MAIN(GenericClient) {
253 base::MessageLoopForIO main_message_loop; 253 base::MessageLoopForIO main_message_loop;
254 GenericChannelListener listener; 254 GenericChannelListener listener;
255 255
256 // Set up IPC channel. 256 // Set up IPC channel.
257 IPC::Channel channel(IPCTestBase::GetChannelName("GenericClient"), 257 scoped_ptr<IPC::Channel> channel(IPC::Channel::CreateClient(
258 IPC::Channel::MODE_CLIENT, 258 IPCTestBase::GetChannelName("GenericClient"),
259 &listener); 259 &listener));
260 CHECK(channel.Connect()); 260 CHECK(channel->Connect());
261 listener.Init(&channel); 261 listener.Init(channel.get());
262 Send(&channel, "hello from child"); 262 Send(channel.get(), "hello from child");
263 263
264 base::MessageLoop::current()->Run(); 264 base::MessageLoop::current()->Run();
265 return 0; 265 return 0;
266 } 266 }
267 267
268 } // namespace 268 } // namespace
OLDNEW
« no previous file with comments | « ipc/ipc_channel_proxy_unittest.cc ('k') | ipc/ipc_fuzzing_tests.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698