Introduce IPC::Channel::Create*() to ensure it being heap-allocated.

ipc/ipc_channel_posix_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // These tests are POSIX only.
 
 #include "ipc/ipc_channel_posix.h"
 
 #include <fcntl.h>
 #include <sys/socket.h>
@@ skipping 186 matching lines @@
 }
 
 TEST_F(IPCChannelPosixTest, BasicListen) {
   const std::string kChannelName =
       GetChannelDirName() + "/IPCChannelPosixTest_BasicListen";
 
   // Test creating a socket that is listening.
   IPC::ChannelHandle handle(kChannelName);
   SetUpSocket(&handle, IPC::Channel::MODE_NAMED_SERVER);
   unlink(handle.name.c_str());
-  IPC::Channel channel(handle, IPC::Channel::MODE_NAMED_SERVER, NULL);
-  ASSERT_TRUE(channel.Connect());
-  ASSERT_TRUE(channel.AcceptsConnections());
-  ASSERT_FALSE(channel.HasAcceptedConnection());
-  channel.ResetToAcceptingConnectionState();
-  ASSERT_FALSE(channel.HasAcceptedConnection());
+  scoped_ptr<IPC::Channel> channel(
+      IPC::Channel::CreateNamedServer(handle, NULL));
+  ASSERT_TRUE(channel->Connect());
+  ASSERT_TRUE(channel->AcceptsConnections());
+  ASSERT_FALSE(channel->HasAcceptedConnection());
+  channel->ResetToAcceptingConnectionState();
+  ASSERT_FALSE(channel->HasAcceptedConnection());
 }
 
 TEST_F(IPCChannelPosixTest, BasicConnected) {
   // Test creating a socket that is connected.
   int pipe_fds[2];
   ASSERT_EQ(0, socketpair(AF_UNIX, SOCK_STREAM, 0, pipe_fds));
   std::string socket_name("/var/tmp/IPCChannelPosixTest_BasicConnected");
   ASSERT_GE(fcntl(pipe_fds[0], F_SETFL, O_NONBLOCK), 0);
 
   base::FileDescriptor fd(pipe_fds[0], false);
   IPC::ChannelHandle handle(socket_name, fd);
-  IPC::Channel channel(handle, IPC::Channel::MODE_SERVER, NULL);
-  ASSERT_TRUE(channel.Connect());
-  ASSERT_FALSE(channel.AcceptsConnections());
-  channel.Close();
+  scoped_ptr<IPC::Channel> channel(IPC::Channel::CreateServer(handle, NULL));
+  ASSERT_TRUE(channel->Connect());
+  ASSERT_FALSE(channel->AcceptsConnections());
+  channel->Close();
   ASSERT_TRUE(IGNORE_EINTR(close(pipe_fds[1])) == 0);
 
   // Make sure that we can use the socket that is created for us by
   // a standard channel.
-  IPC::Channel channel2(socket_name, IPC::Channel::MODE_SERVER, NULL);
-  ASSERT_TRUE(channel2.Connect());
-  ASSERT_FALSE(channel2.AcceptsConnections());
+  scoped_ptr<IPC::Channel> channel2(
+      IPC::Channel::CreateServer(socket_name, NULL));
+  ASSERT_TRUE(channel2->Connect());
+  ASSERT_FALSE(channel2->AcceptsConnections());
 }
 
 // If a connection closes right before a Send() call, we may end up closing
 // the connection without notifying the listener, which can cause hangs in
 // sync_message_filter and others. Make sure the listener is notified.
 TEST_F(IPCChannelPosixTest, SendHangTest) {
   IPCChannelPosixTestListener out_listener(true);
   IPCChannelPosixTestListener in_listener(true);
   IPC::ChannelHandle in_handle("IN");
-  IPC::Channel in_chan(in_handle, IPC::Channel::MODE_SERVER, &in_listener);
-  base::FileDescriptor out_fd(in_chan.TakeClientFileDescriptor(), false);
+  scoped_ptr<IPC::Channel> in_chan(
+      IPC::Channel::CreateServer(in_handle, &in_listener));
+  base::FileDescriptor out_fd(in_chan->TakeClientFileDescriptor(), false);
   IPC::ChannelHandle out_handle("OUT", out_fd);
-  IPC::Channel out_chan(out_handle, IPC::Channel::MODE_CLIENT, &out_listener);
-  ASSERT_TRUE(in_chan.Connect());
-  ASSERT_TRUE(out_chan.Connect());
-  in_chan.Close();  // simulate remote process dying at an unfortunate time.
+  scoped_ptr<IPC::Channel> out_chan(
+      IPC::Channel::CreateClient(out_handle, &out_listener));
+  ASSERT_TRUE(in_chan->Connect());
+  ASSERT_TRUE(out_chan->Connect());
+  in_chan->Close();  // simulate remote process dying at an unfortunate time.
   // Send will fail, because it cannot write the message.
-  ASSERT_FALSE(out_chan.Send(new IPC::Message(
+  ASSERT_FALSE(out_chan->Send(new IPC::Message(
       0,  // routing_id
       kQuitMessage,  // message type
       IPC::Message::PRIORITY_NORMAL)));
   SpinRunLoop(TestTimeouts::action_max_timeout());
   ASSERT_EQ(IPCChannelPosixTestListener::CHANNEL_ERROR, out_listener.status());
 }
 
 // If a connection closes right before a Connect() call, we may end up closing
 // the connection without notifying the listener, which can cause hangs in
 // sync_message_filter and others. Make sure the listener is notified.
 TEST_F(IPCChannelPosixTest, AcceptHangTest) {
   IPCChannelPosixTestListener out_listener(true);
   IPCChannelPosixTestListener in_listener(true);
   IPC::ChannelHandle in_handle("IN");
-  IPC::Channel in_chan(in_handle, IPC::Channel::MODE_SERVER, &in_listener);
-  base::FileDescriptor out_fd(in_chan.TakeClientFileDescriptor(), false);
+  scoped_ptr<IPC::Channel> in_chan(
+      IPC::Channel::CreateServer(in_handle, &in_listener));
+  base::FileDescriptor out_fd(in_chan->TakeClientFileDescriptor(), false);
   IPC::ChannelHandle out_handle("OUT", out_fd);
-  IPC::Channel out_chan(out_handle, IPC::Channel::MODE_CLIENT, &out_listener);
-  ASSERT_TRUE(in_chan.Connect());
-  in_chan.Close();  // simulate remote process dying at an unfortunate time.
-  ASSERT_FALSE(out_chan.Connect());
+  scoped_ptr<IPC::Channel> out_chan(
+      IPC::Channel::CreateClient(out_handle, &out_listener));
+  ASSERT_TRUE(in_chan->Connect());
+  in_chan->Close();  // simulate remote process dying at an unfortunate time.
+  ASSERT_FALSE(out_chan->Connect());
   SpinRunLoop(TestTimeouts::action_max_timeout());
   ASSERT_EQ(IPCChannelPosixTestListener::CHANNEL_ERROR, out_listener.status());
 }
 
 TEST_F(IPCChannelPosixTest, AdvancedConnected) {
   // Test creating a connection to an external process.
   IPCChannelPosixTestListener listener(false);
   IPC::ChannelHandle chan_handle(GetConnectionSocketName());
   SetUpSocket(&chan_handle, IPC::Channel::MODE_NAMED_SERVER);
-  IPC::Channel channel(chan_handle, IPC::Channel::MODE_NAMED_SERVER, &listener);
-  ASSERT_TRUE(channel.Connect());
-  ASSERT_TRUE(channel.AcceptsConnections());
-  ASSERT_FALSE(channel.HasAcceptedConnection());
+  scoped_ptr<IPC::Channel> channel(
+      IPC::Channel::CreateNamedServer(chan_handle, &listener));
+  ASSERT_TRUE(channel->Connect());
+  ASSERT_TRUE(channel->AcceptsConnections());
+  ASSERT_FALSE(channel->HasAcceptedConnection());
 
   base::ProcessHandle handle = SpawnChild("IPCChannelPosixTestConnectionProc");
   ASSERT_TRUE(handle);
   SpinRunLoop(TestTimeouts::action_max_timeout());
   ASSERT_EQ(IPCChannelPosixTestListener::CONNECTED, listener.status());
-  ASSERT_TRUE(channel.HasAcceptedConnection());
+  ASSERT_TRUE(channel->HasAcceptedConnection());
   IPC::Message* message = new IPC::Message(0,  // routing_id
                                            kQuitMessage,  // message type
                                            IPC::Message::PRIORITY_NORMAL);
-  channel.Send(message);
+  channel->Send(message);
   SpinRunLoop(TestTimeouts::action_timeout());
   int exit_code = 0;
   EXPECT_TRUE(base::WaitForExitCode(handle, &exit_code));
   EXPECT_EQ(0, exit_code);
   ASSERT_EQ(IPCChannelPosixTestListener::CHANNEL_ERROR, listener.status());
-  ASSERT_FALSE(channel.HasAcceptedConnection());
+  ASSERT_FALSE(channel->HasAcceptedConnection());
 }
 
 TEST_F(IPCChannelPosixTest, ResetState) {
   // Test creating a connection to an external process. Close the connection,
   // but continue to listen and make sure another external process can connect
   // to us.
   IPCChannelPosixTestListener listener(false);
   IPC::ChannelHandle chan_handle(GetConnectionSocketName());
   SetUpSocket(&chan_handle, IPC::Channel::MODE_NAMED_SERVER);
-  IPC::Channel channel(chan_handle, IPC::Channel::MODE_NAMED_SERVER, &listener);
-  ASSERT_TRUE(channel.Connect());
-  ASSERT_TRUE(channel.AcceptsConnections());
-  ASSERT_FALSE(channel.HasAcceptedConnection());
+  scoped_ptr<IPC::Channel> channel(
+      IPC::Channel::CreateNamedServer(chan_handle, &listener));
+  ASSERT_TRUE(channel->Connect());
+  ASSERT_TRUE(channel->AcceptsConnections());
+  ASSERT_FALSE(channel->HasAcceptedConnection());
 
   base::ProcessHandle handle = SpawnChild("IPCChannelPosixTestConnectionProc");
   ASSERT_TRUE(handle);
   SpinRunLoop(TestTimeouts::action_max_timeout());
   ASSERT_EQ(IPCChannelPosixTestListener::CONNECTED, listener.status());
-  ASSERT_TRUE(channel.HasAcceptedConnection());
-  channel.ResetToAcceptingConnectionState();
-  ASSERT_FALSE(channel.HasAcceptedConnection());
+  ASSERT_TRUE(channel->HasAcceptedConnection());
+  channel->ResetToAcceptingConnectionState();
+  ASSERT_FALSE(channel->HasAcceptedConnection());
 
   base::ProcessHandle handle2 = SpawnChild("IPCChannelPosixTestConnectionProc");
   ASSERT_TRUE(handle2);
   SpinRunLoop(TestTimeouts::action_max_timeout());
   ASSERT_EQ(IPCChannelPosixTestListener::CONNECTED, listener.status());
-  ASSERT_TRUE(channel.HasAcceptedConnection());
+  ASSERT_TRUE(channel->HasAcceptedConnection());
   IPC::Message* message = new IPC::Message(0,  // routing_id
                                            kQuitMessage,  // message type
                                            IPC::Message::PRIORITY_NORMAL);
-  channel.Send(message);
+  channel->Send(message);
   SpinRunLoop(TestTimeouts::action_timeout());
   EXPECT_TRUE(base::KillProcess(handle, 0, false));
   int exit_code = 0;
   EXPECT_TRUE(base::WaitForExitCode(handle2, &exit_code));
   EXPECT_EQ(0, exit_code);
   ASSERT_EQ(IPCChannelPosixTestListener::CHANNEL_ERROR, listener.status());
-  ASSERT_FALSE(channel.HasAcceptedConnection());
+  ASSERT_FALSE(channel->HasAcceptedConnection());
 }
 
 TEST_F(IPCChannelPosixTest, BadChannelName) {
   // Test empty name
   IPC::ChannelHandle handle("");
-  IPC::Channel channel(handle, IPC::Channel::MODE_NAMED_SERVER, NULL);
-  ASSERT_FALSE(channel.Connect());
+  scoped_ptr<IPC::Channel> channel(
+      IPC::Channel::CreateNamedServer(handle, NULL));
+  ASSERT_FALSE(channel->Connect());
 
   // Test name that is too long.
   const char *kTooLongName = "This_is_a_very_long_name_to_proactively_implement"
                              "client-centered_synergy_through_top-line"
                              "platforms_Phosfluorescently_disintermediate_"
                              "clicks-and-mortar_best_practices_without_"
                              "future-proof_growth_strategies_Continually"
                              "pontificate_proactive_potentialities_before"
                              "leading-edge_processes";
   EXPECT_GE(strlen(kTooLongName), IPC::kMaxSocketNameLength);
   IPC::ChannelHandle handle2(kTooLongName);
-  IPC::Channel channel2(handle2, IPC::Channel::MODE_NAMED_SERVER, NULL);
-  EXPECT_FALSE(channel2.Connect());
+  scoped_ptr<IPC::Channel> channel2(
+      IPC::Channel::CreateNamedServer(handle2, NULL));
+  EXPECT_FALSE(channel2->Connect());
 }
 
 TEST_F(IPCChannelPosixTest, MultiConnection) {
   // Test setting up a connection to an external process, and then have
   // another external process attempt to connect to us.
   IPCChannelPosixTestListener listener(false);
   IPC::ChannelHandle chan_handle(GetConnectionSocketName());
   SetUpSocket(&chan_handle, IPC::Channel::MODE_NAMED_SERVER);
-  IPC::Channel channel(chan_handle, IPC::Channel::MODE_NAMED_SERVER, &listener);
-  ASSERT_TRUE(channel.Connect());
-  ASSERT_TRUE(channel.AcceptsConnections());
-  ASSERT_FALSE(channel.HasAcceptedConnection());
+  scoped_ptr<IPC::Channel> channel(
+      IPC::Channel::CreateNamedServer(chan_handle, &listener));
+  ASSERT_TRUE(channel->Connect());
+  ASSERT_TRUE(channel->AcceptsConnections());
+  ASSERT_FALSE(channel->HasAcceptedConnection());
 
   base::ProcessHandle handle = SpawnChild("IPCChannelPosixTestConnectionProc");
   ASSERT_TRUE(handle);
   SpinRunLoop(TestTimeouts::action_max_timeout());
   ASSERT_EQ(IPCChannelPosixTestListener::CONNECTED, listener.status());
-  ASSERT_TRUE(channel.HasAcceptedConnection());
+  ASSERT_TRUE(channel->HasAcceptedConnection());
   base::ProcessHandle handle2 = SpawnChild("IPCChannelPosixFailConnectionProc");
   ASSERT_TRUE(handle2);
   SpinRunLoop(TestTimeouts::action_max_timeout());
   int exit_code = 0;
   EXPECT_TRUE(base::WaitForExitCode(handle2, &exit_code));
   EXPECT_EQ(exit_code, 0);
   ASSERT_EQ(IPCChannelPosixTestListener::DENIED, listener.status());
-  ASSERT_TRUE(channel.HasAcceptedConnection());
+  ASSERT_TRUE(channel->HasAcceptedConnection());
   IPC::Message* message = new IPC::Message(0,  // routing_id
                                            kQuitMessage,  // message type
                                            IPC::Message::PRIORITY_NORMAL);
-  channel.Send(message);
+  channel->Send(message);
   SpinRunLoop(TestTimeouts::action_timeout());
   EXPECT_TRUE(base::WaitForExitCode(handle, &exit_code));
   EXPECT_EQ(exit_code, 0);
   ASSERT_EQ(IPCChannelPosixTestListener::CHANNEL_ERROR, listener.status());
-  ASSERT_FALSE(channel.HasAcceptedConnection());
+  ASSERT_FALSE(channel->HasAcceptedConnection());
 }
 
 TEST_F(IPCChannelPosixTest, DoubleServer) {
   // Test setting up two servers with the same name.
   IPCChannelPosixTestListener listener(false);
   IPCChannelPosixTestListener listener2(false);
   IPC::ChannelHandle chan_handle(GetConnectionSocketName());
-  IPC::Channel channel(chan_handle, IPC::Channel::MODE_SERVER, &listener);
-  IPC::Channel channel2(chan_handle, IPC::Channel::MODE_SERVER, &listener2);
-  ASSERT_TRUE(channel.Connect());
-  ASSERT_FALSE(channel2.Connect());
+  scoped_ptr<IPC::Channel> channel(
+      IPC::Channel::CreateServer(chan_handle, &listener));
+  scoped_ptr<IPC::Channel> channel2(
+      IPC::Channel::CreateServer(chan_handle, &listener2));
+  ASSERT_TRUE(channel->Connect());
+  ASSERT_FALSE(channel2->Connect());
 }
 
 TEST_F(IPCChannelPosixTest, BadMode) {
   // Test setting up two servers with a bad mode.
   IPCChannelPosixTestListener listener(false);
   IPC::ChannelHandle chan_handle(GetConnectionSocketName());
-  IPC::Channel channel(chan_handle, IPC::Channel::MODE_NONE, &listener);
-  ASSERT_FALSE(channel.Connect());
+  scoped_ptr<IPC::Channel> channel(IPC::Channel::CreateByModeForProxy(
+      chan_handle, IPC::Channel::MODE_NONE, &listener));
+  ASSERT_FALSE(channel->Connect());
 }
 
 TEST_F(IPCChannelPosixTest, IsNamedServerInitialized) {
   const std::string& connection_socket_name = GetConnectionSocketName();
   IPCChannelPosixTestListener listener(false);
   IPC::ChannelHandle chan_handle(connection_socket_name);
   ASSERT_TRUE(base::DeleteFile(base::FilePath(connection_socket_name), false));
   ASSERT_FALSE(IPC::Channel::IsNamedServerInitialized(
       connection_socket_name));
-  IPC::Channel channel(chan_handle, IPC::Channel::MODE_NAMED_SERVER, &listener);
+  scoped_ptr<IPC::Channel> channel(
+      IPC::Channel::CreateNamedServer(chan_handle, &listener));
   ASSERT_TRUE(IPC::Channel::IsNamedServerInitialized(
       connection_socket_name));
-  channel.Close();
+  channel->Close();
   ASSERT_FALSE(IPC::Channel::IsNamedServerInitialized(
       connection_socket_name));
 }
 
 // A long running process that connects to us
 MULTIPROCESS_TEST_MAIN(IPCChannelPosixTestConnectionProc) {
   base::MessageLoopForIO message_loop;
   IPCChannelPosixTestListener listener(true);
   IPC::ChannelHandle handle(IPCChannelPosixTest::GetConnectionSocketName());
   IPCChannelPosixTest::SetUpSocket(&handle, IPC::Channel::MODE_NAMED_CLIENT);
-  IPC::Channel channel(handle, IPC::Channel::MODE_NAMED_CLIENT, &listener);
-  EXPECT_TRUE(channel.Connect());
+  scoped_ptr<IPC::Channel> channel(
+      IPC::Channel::CreateNamedClient(handle, &listener));
+  EXPECT_TRUE(channel->Connect());
   IPCChannelPosixTest::SpinRunLoop(TestTimeouts::action_max_timeout());
   EXPECT_EQ(IPCChannelPosixTestListener::MESSAGE_RECEIVED, listener.status());
   return 0;
 }
 
 // Simple external process that shouldn't be able to connect to us.
 MULTIPROCESS_TEST_MAIN(IPCChannelPosixFailConnectionProc) {
   base::MessageLoopForIO message_loop;
   IPCChannelPosixTestListener listener(false);
   IPC::ChannelHandle handle(IPCChannelPosixTest::GetConnectionSocketName());
   IPCChannelPosixTest::SetUpSocket(&handle, IPC::Channel::MODE_NAMED_CLIENT);
-  IPC::Channel channel(handle, IPC::Channel::MODE_NAMED_CLIENT, &listener);
+  scoped_ptr<IPC::Channel> channel(
+      IPC::Channel::CreateNamedClient(handle, &listener));
 
   // In this case connect may succeed or fail depending on if the packet
   // actually gets sent at sendmsg. Since we never delay on send, we may not
   // see the error. However even if connect succeeds, eventually we will get an
   // error back since the channel will be closed when we attempt to read from
   // it.
-  bool connected = channel.Connect();
+  bool connected = channel->Connect();
   if (connected) {
     IPCChannelPosixTest::SpinRunLoop(TestTimeouts::action_max_timeout());
     EXPECT_EQ(IPCChannelPosixTestListener::CHANNEL_ERROR, listener.status());
   } else {
     EXPECT_EQ(IPCChannelPosixTestListener::DISCONNECTED, listener.status());
   }
   return 0;
 }
 
 }  // namespace