Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 307623003: [DevTools] Apps implementation. (Closed)

Created:
6 years, 6 months ago by dgozman
Modified:
6 years, 6 months ago
Reviewers:
apavlov, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

[DevTools] Apps implementation. DevTools frontend now runs an app: screencast app, simple undocked app or advanced app with docking support. There will be a toolbox app soon (the always-docked part of DevTools). This patch mostly moves the code into the new WebInspector.App hierarchy. BUG=none R=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175060

Patch Set 1 #

Total comments: 2

Patch Set 2 : Split files #

Patch Set 3 : rebased #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+310 lines, -202 lines) Patch
M Source/devtools/devtools.gypi View 1 1 chunk +4 lines, -0 lines 0 comments Download
M Source/devtools/front_end/ScreencastView.js View 1 chunk +0 lines, -76 lines 0 comments Download
M Source/devtools/front_end/components/DockController.js View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/devtools/front_end/components/InspectedPagePlaceholder.js View 4 chunks +10 lines, -33 lines 0 comments Download
M Source/devtools/front_end/inspector.html View 1 1 chunk +4 lines, -0 lines 0 comments Download
A Source/devtools/front_end/main/AdvancedApp.js View 1 2 1 chunk +111 lines, -0 lines 1 comment Download
A Source/devtools/front_end/main/App.js View 1 1 chunk +45 lines, -0 lines 0 comments Download
M Source/devtools/front_end/main/Main.js View 1 2 6 chunks +16 lines, -92 lines 0 comments Download
A Source/devtools/front_end/main/ScreencastApp.js View 1 1 chunk +75 lines, -0 lines 0 comments Download
A Source/devtools/front_end/main/SimpleApp.js View 1 1 chunk +29 lines, -0 lines 0 comments Download
M Source/devtools/front_end/ui/StatusBarButton.js View 2 chunks +6 lines, -1 line 0 comments Download
M Source/devtools/scripts/frontend_modules.json View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
dgozman
Take a look please.
6 years, 6 months ago (2014-05-28 12:34:03 UTC) #1
aandrey
On 2014/05/28 12:34:03, dgozman wrote: > Apps implementation. what is this?
6 years, 6 months ago (2014-05-28 12:36:29 UTC) #2
dgozman
On 2014/05/28 12:36:29, aandrey wrote: > On 2014/05/28 12:34:03, dgozman wrote: > > Apps implementation. ...
6 years, 6 months ago (2014-05-28 12:39:57 UTC) #3
pfeldman
lgtm w/ nits https://codereview.chromium.org/307623003/diff/1/Source/devtools/front_end/main/App.js File Source/devtools/front_end/main/App.js (right): https://codereview.chromium.org/307623003/diff/1/Source/devtools/front_end/main/App.js#newcode79 Source/devtools/front_end/main/App.js:79: WebInspector.AdvancedApp = function() These all should ...
6 years, 6 months ago (2014-05-28 15:12:00 UTC) #4
dgozman
The CQ bit was checked by dgozman@chromium.org
6 years, 6 months ago (2014-05-29 10:03:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/307623003/40001
6 years, 6 months ago (2014-05-29 10:04:28 UTC) #6
dgozman
Committed patchset #3 manually as r175060 (presubmit successful).
6 years, 6 months ago (2014-05-29 15:44:20 UTC) #7
apavlov
Can we have a bug tracking all the UI structure changes going on lately? Us ...
6 years, 6 months ago (2014-05-29 15:50:23 UTC) #8
dgozman
On 2014/05/29 15:50:23, apavlov wrote: > Can we have a bug tracking all the UI ...
6 years, 6 months ago (2014-05-29 15:51:51 UTC) #9
apavlov
6 years, 6 months ago (2014-05-29 15:54:04 UTC) #10
Message was sent while issue was closed.
https://codereview.chromium.org/307623003/diff/40001/Source/devtools/front_en...
File Source/devtools/front_end/main/AdvancedApp.js (right):

https://codereview.chromium.org/307623003/diff/40001/Source/devtools/front_en...
Source/devtools/front_end/main/AdvancedApp.js:15: createGlobalStatusBarItems:
function()
These apps should certainly go into different modules, since they are going to
provide different sets of contributions (e.g. see my
https://codereview.chromium.org/283063003/ (pending review), which has just
rotten to death.)

Powered by Google App Engine
This is Rietveld 408576698