Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 307613002: Refine the UseCounters for DOMFocusIn/Out and focusin/out events (Closed)

Created:
6 years, 6 months ago by philipj_slow
Modified:
6 years, 6 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Visibility:
Public.

Description

Refine the UseCounters for DOMFocusIn/Out and focusin/out events Hixie asked in bug 378163: "Should we drop focusin/focusout?" "Is there a compat need to support the focusin/focusout events?" To answer that question, add a UseCounter for focusin/focusout. Instead of counting all listeners, count cases where the event is actually fired with a listener attached, which is a better estimate of the compatibility risk. Make the same change to the DOMFocusInOut counter to make the two comparable. BUG=378163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175014

Patch Set 1 #

Patch Set 2 : less wrong #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M Source/core/dom/Document.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/events/EventTarget.cpp View 1 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
philipj_slow
tkent, you added the DOMFocusInOut counter, can you PTAL?
6 years, 6 months ago (2014-05-28 12:13:43 UTC) #1
philipj_slow
Wait, PS1 won't work, because hasEventListeners will only catch event listeners attached to the same ...
6 years, 6 months ago (2014-05-28 21:48:35 UTC) #2
philipj_slow
There, I think PS2 ought to do it. EventTarget.cpp looks ready for a helper function ...
6 years, 6 months ago (2014-05-28 23:01:39 UTC) #3
tkent
lgtm
6 years, 6 months ago (2014-05-28 23:04:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/307613002/20001
6 years, 6 months ago (2014-05-28 23:04:43 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-05-29 00:20:36 UTC) #6
Message was sent while issue was closed.
Change committed as 175014

Powered by Google App Engine
This is Rietveld 408576698