Issue 3076032: [Isolates] A fix for 2 crashing tests in arm simulator (post-API patch).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3076032: [Isolates] A fix for 2 crashing tests in arm simulator (post-API patch). (Closed)

Created:
10 years, 4 months ago by Dmitry Titov

Modified:
9 years, 7 months ago

Reviewers:
Vitaly Repeshko, zarko

CC:
v8-dev

Visibility:
Public.

Description

[Isolates] A fix for 2 crashing tests in arm simulator (post-API patch). Need to keep a per-isolate/per-thread instance of Simulator, rather then have one Simulator per thread as was before. Also, need to enter default isolate in Simulator::current() since APIs like SetResourceConstraints require a Simulator before V8::Initialize. Committed: http://code.google.com/p/v8/source/detail?r=5200

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -19 lines)			Patch
M	src/arm/simulator-arm.cc	View	1 chunk	+11 lines, -7 lines	0 comments	Download
M	src/isolate.h	View	6 chunks	+16 lines, -6 lines	0 comments	Download
M	src/isolate.cc	View	2 chunks	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

On 2010/08/04 22:44:16, Dmitry Titov wrote:
> 

LGTM

Expand Messages | Collapse Messages