Issue 3076030: Leaks found in PrefValueStoreTest tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3076030: Leaks found in PrefValueStoreTest tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by dhollowa

Modified:
4 years ago

Reviewers:
stuartmorgan, danno

CC:
chromium-reviews, Timur Iskhodzhanov, stuartmorgan, pam+watch_chromium.org, Alexander Potapenko

Visibility:
Public.

Description

Leaks found in PrefValueStoreTest tests Suppresses leaks apparently introduced in revision 54902. http://codereview.chromium.org/2858060 BUG=51176, 45324 TEST=Run Valgrind. No leaks reported. PrefValueStoreTest.TestRefreshPolicyPrefsCompletion, PrefValueStoreTest.TestRefreshPolicyPrefsCompletion, PrefValueStoreTest.TestConcurrentPolicyRefresh Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54943

Patch Set 1 #

Total comments: 2

Patch Set 2 : Trimming test harness info. #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -0 lines)			Patch
	M	tools/heapcheck/suppressions.txt	View		1 chunk	+18 lines, -0 lines	0 comments	Download
	M	tools/valgrind/memcheck/suppressions.txt	View	1	1 chunk	+18 lines, -0 lines	0 comments	Download

Trybot results:

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

stuartmorgan

http://codereview.chromium.org/3076030/diff/1/3 File tools/valgrind/memcheck/suppressions.txt (right): http://codereview.chromium.org/3076030/diff/1/3#newcode3906 tools/valgrind/memcheck/suppressions.txt:3906: fun:_ZN7testing4Test3RunEv Trim from here on in all the suppressions; ...

4 years, 10 months ago (2010-08-04 19:20:25 UTC) #2

dhollowa

4 years, 10 months ago (2010-08-04 19:23:58 UTC) #3

LGTM

Expand Messages | Collapse Messages