IMC: Remove ReturnCreatedDesc() method from effector object

IMC: Remove ReturnCreatedDesc() method from effector object

Change the ConnectAddr() and AcceptConn() methods to return a NaClDesc
rather than a descriptor number.

This means the syscall function is now responsible for adding the
descriptor into the FD table with NaClSetAvail(), which is consistent
with the other syscall functions.

This means we can remove NaClNrdXferEffectorDtor(), which was a
workaround for cases where a NaClDesc was what the caller wanted from
ConnectAddr()/AcceptConn().

This removes the need to create effector objects in some cases.

BUG=http://code.google.com/p/nativeclient/issues/detail?id=727
TEST=existing tests

Committed: http://code.google.com/p/nativeclient/source/detail?r=2827

[Mark Schneckloth, 2010-07-28 16:39:59]

LGTM

http://codereview.chromium.org/3076010/diff/1/11
File src/native_client/src/trusted/desc/nrd_xfer_effector.c (right):

http://codereview.chromium.org/3076010/diff/1/11#newcode56
src/native_client/src/trusted/desc/nrd_xfer_effector.c:56: };
It doesn't look like this "class" (NaClNrdXferEffector) does much anymore.  Will
it be deleted in another round of clean up?

[Mark Seaborn, 2010-07-29 12:58:16]

On 2010/07/28 16:39:59, Mark Schneckloth wrote:
> LGTM
> 
> http://codereview.chromium.org/3076010/diff/1/11
> File src/native_client/src/trusted/desc/nrd_xfer_effector.c (right):
> 
> http://codereview.chromium.org/3076010/diff/1/11#newcode56
> src/native_client/src/trusted/desc/nrd_xfer_effector.c:56: };
> It doesn't look like this "class" (NaClNrdXferEffector) does much
> anymore.  Will it be deleted in another round of clean up?

I think it might be possible to do that, yes.  It is still used as a
dummy effector but it should be possible to reduce the need for dummy
effectors.