Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2784)

Unified Diff: chrome/browser/sync/syncable/syncable.cc

Issue 3076008: sync: change to demonstrate where syncable leak is. (Closed) Base URL: git://git.chromium.org/chromium.git
Patch Set: Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/syncable/syncable.cc
diff --git a/chrome/browser/sync/syncable/syncable.cc b/chrome/browser/sync/syncable/syncable.cc
index a2a9a98599b010e7d22b69e29ff1c8fd54a41fc4..38ddb45185724e4a57cb524ec95987d445dc77d5 100644
--- a/chrome/browser/sync/syncable/syncable.cc
+++ b/chrome/browser/sync/syncable/syncable.cc
@@ -260,8 +260,10 @@ DirOpenResult Directory::OpenImpl(const FilePath& file_path,
// swap these later.
MetahandlesIndex metas_bucket;
DirOpenResult result = store_->Load(&metas_bucket, &info);
- if (OPENED != result)
+ if (OPENED != result) {
+ // XXX need to free all the crap in metas_bucket here.
return result;
+ }
kernel_ = new Kernel(db_path, name, info);
kernel_->metahandles_index->swap(metas_bucket);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698