Preliminary support for block contexts in hydrogen.

test/mjsunit/harmony/block-scoping.js

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 10 matching lines @@
 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 // Flags: --allow-natives-syntax --harmony-scoping
 // Test functionality of block scopes.
 
 // TODO(ES6): properly activate extended mode

[rossberg, 2014/06/04 12:54:53]

Btw, we can remove this TODO now.

[ulan, 2014/06/04 14:02:05]

Done.

 "use strict";
 
 // Hoisting of var declarations.
 function f1() {
   {
     var x = 1;
     var y;
   }
   assertEquals(1, x)
   assertEquals(undefined, y)
 }
+for (var j = 0; j < 5; ++j) f1();
+%OptimizeFunctionOnNextCall(f1);
 f1();
-
+assertTrue(%GetOptimizationStatus(f1) != 2);
 
 // Dynamic lookup in and through block contexts.
 function f2(one) {
   var x = one + 1;
   let y = one + 2;
   const u = one + 4;
   {
     let z = one + 3;
     const v = one + 5;
     assertEquals(1, eval('one'));
     assertEquals(2, eval('x'));
     assertEquals(3, eval('y'));
     assertEquals(4, eval('z'));
     assertEquals(5, eval('u'));
     assertEquals(6, eval('v'));
   }
 }
+for (var j = 0; j < 5; ++j) f2(1);
+%OptimizeFunctionOnNextCall(f2);
 f2(1);
 

[rossberg, 2014/06/04 12:54:53]

Why not assert optimization status here as well (and below)?

[ulan, 2014/06/04 14:02:05]

Did it for the function below. This function doesn't get optimized because of
eval, so I removed %OptimizeFunctionOnNextCall for it.

 
 // Lookup in and through block contexts.
 function f3(one) {
   var x = one + 1;
   let y = one + 2;
   const u = one + 4;
   {
     let z = one + 3;
     const v = one + 5;
     assertEquals(1, one);
     assertEquals(2, x);
     assertEquals(3, y);
     assertEquals(4, z);
     assertEquals(5, u);
     assertEquals(6, v);
-
   }
 }
+for (var j = 0; j < 5; ++j) f3(1);
+%OptimizeFunctionOnNextCall(f3);
 f3(1);
 
 
 // Dynamic lookup from closure.
 function f4(one) {
   var x = one + 1;
   let y = one + 2;
   const u = one + 4;
   {
     let z = one + 3;
@@ skipping 164 matching lines @@
     const_accessors[i] = function() { return z; }
   }
   for (var j = 0; j < 10; j++) {
     y = j + 10;
     assertEquals(j, let_accessors[j]());
     assertEquals(y, var_accessors[j]());
     assertEquals(j, const_accessors[j]());
   }
 }
 f8();