tools/testrunner/local/execution.py - Issue 307553003: Add flag to test harness to stop sorting test cases.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testrunner/local/execution.py

Issue 307553003: Add flag to test harness to stop sorting test cases. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed comments by Jakob Kummerow. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/testrunner/local/execution.py

diff --git a/tools/testrunner/local/execution.py b/tools/testrunner/local/execution.py

index 4dc62c2e90066032c2dd3412987a729786c14b9c..80a5989be2f255a672b872adca74b284ad2ef49c 100644

--- a/tools/testrunner/local/execution.py

+++ b/tools/testrunner/local/execution.py

@@ -94,7 +94,9 @@ class Runner(object):

# while the queue is filled.

queue = []

queued_exception = None

- for test in sorted(self.tests, key=lambda t: t.duration, reverse=True):

+ if not self.context.no_sorting:

+ self.tests = sorted(self.tests, key=lambda t: t.duration, reverse=True)

Michael Achenbach 2014/05/28 11:08:32 Not totally happy with replacing generators with c

Jakob Kummerow 2014/05/28 11:12:16 Right, should probably use self.tests.sort(key=...

Michael Starzinger 2014/05/28 11:24:56 Will upload a follow-up CL to address this.

+ for test in self.tests:

assert test.id >= 0

test_map[test.id] = test

try:

« no previous file with comments | « tools/run-tests.py ('k') | tools/testrunner/objects/context.py » ('j') | no next file with comments »