|
Simplify, speed-up correct-context ObjectObserve calls
The original patch which ensured that Object.observe did allocations in the correct context regressed performance about 12%. This patch gets back most of that (about 11%) by simply returning the correct function which is then directly callable from JS, rather than by making the call from the runtime function. A side-effect is that their implementation is shorter.
LOG=Y
BUG=NONE
R=verwaest@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=21575
Total comments: 1
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+21 lines, -69 lines) |
Patch |
|
M |
src/object-observe.js
|
View
|
1
2
|
3 chunks |
+6 lines, -4 lines |
0 comments
|
Download
|
|
M |
src/runtime.h
|
View
|
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
|
M |
src/runtime.cc
|
View
|
|
1 chunk |
+8 lines, -39 lines |
0 comments
|
Download
|
|
A + |
test/mjsunit/runtime-gen/getobjectcontextnotifierperformchange.js
|
View
|
1
2
3
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
A + |
test/mjsunit/runtime-gen/getobjectcontextobjectgetnotifier.js
|
View
|
1
2
3
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
A + |
test/mjsunit/runtime-gen/getobjectcontextobjectobserve.js
|
View
|
1
2
3
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
D |
test/mjsunit/runtime-gen/objectgetnotifierinobjectcontext.js
|
View
|
1
2
3
|
1 chunk |
+0 lines, -5 lines |
0 comments
|
Download
|
|
D |
test/mjsunit/runtime-gen/objectnotifierperformchangeinobjectcontext.js
|
View
|
1
2
3
|
1 chunk |
+0 lines, -7 lines |
0 comments
|
Download
|
|
D |
test/mjsunit/runtime-gen/objectobserveinobjectcontext.js
|
View
|
1
2
3
|
1 chunk |
+0 lines, -7 lines |
0 comments
|
Download
|
Total messages: 4 (0 generated)
|