Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 307543008: Simplify, speed-up correct-context ObjectObserve calls (Closed)

Created:
6 years, 7 months ago by rafaelw
Modified:
6 years, 6 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev, adamk, dcarney
Visibility:
Public.

Description

Simplify, speed-up correct-context ObjectObserve calls The original patch which ensured that Object.observe did allocations in the correct context regressed performance about 12%. This patch gets back most of that (about 11%) by simply returning the correct function which is then directly callable from JS, rather than by making the call from the runtime function. A side-effect is that their implementation is shorter. LOG=Y BUG=NONE R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21575

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : fix #

Patch Set 4 : tests, stray semi-colons #

Total comments: 1

Patch Set 5 : <sigh> remove style fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -69 lines) Patch
M src/object-observe.js View 1 2 3 chunks +6 lines, -4 lines 0 comments Download
M src/runtime.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/runtime.cc View 1 chunk +8 lines, -39 lines 0 comments Download
A + test/mjsunit/runtime-gen/getobjectcontextnotifierperformchange.js View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
A + test/mjsunit/runtime-gen/getobjectcontextobjectgetnotifier.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/runtime-gen/getobjectcontextobjectobserve.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
D test/mjsunit/runtime-gen/objectgetnotifierinobjectcontext.js View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
D test/mjsunit/runtime-gen/objectnotifierperformchangeinobjectcontext.js View 1 2 3 1 chunk +0 lines, -7 lines 0 comments Download
D test/mjsunit/runtime-gen/objectobserveinobjectcontext.js View 1 2 3 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rafaelw
6 years, 7 months ago (2014-05-27 23:35:10 UTC) #1
rafaelw
https://codereview.chromium.org/307543008/diff/50001/src/objects.h File src/objects.h (right): https://codereview.chromium.org/307543008/diff/50001/src/objects.h#newcode8797 src/objects.h:8797: kArrayIndexValueBits> {} These aren't a part of this change. ...
6 years, 7 months ago (2014-05-27 23:48:42 UTC) #2
Toon Verwaest
lgtm
6 years, 7 months ago (2014-05-28 10:54:41 UTC) #3
rafaelw
6 years, 6 months ago (2014-05-28 19:13:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #5 manually as r21575 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698