chrome/renderer/resources/extensions/web_view_experimental.js - Issue 307543005: Fix the Declarative WebRequest API for <webview>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/web_view_experimental.js

Issue 307543005: Fix the Declarative WebRequest API for <webview> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_webcontentsdelegate_impl_to_chrome

Patch Set: Addressed remainder of comments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/renderer/resources/extensions/web_view.js ('K') | « chrome/renderer/resources/extensions/web_view.js ('k') | chrome/test/data/extensions/platform_apps/web_view/shim/main.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/web_view_experimental.js

diff --git a/chrome/renderer/resources/extensions/web_view_experimental.js b/chrome/renderer/resources/extensions/web_view_experimental.js

index 62b3a249e6ab89982e6a5615ecca6481ff9873be..311de4640502b8c6e4442890885c1fe30b36ff5b 100644

--- a/chrome/renderer/resources/extensions/web_view_experimental.js

+++ b/chrome/renderer/resources/extensions/web_view_experimental.js

@@ -122,21 +122,6 @@ var WebViewContextMenus = utils.expose(

'WebViewContextMenus', WebViewContextMenusImpl,

{ functions: ['create', 'remove', 'removeAll', 'update'] });

-/**

- * @private

- */

-WebViewInternal.prototype.maybeAttachWebRequestEventToObject =

- function(obj, eventName, webRequestEvent) {

- Object.defineProperty(

- obj,

- eventName,

- {

- get: webRequestEvent,

- enumerable: true

- }

- );

-};

/** @private */

WebViewInternal.prototype.maybeHandleContextMenu = function(e, webViewEvent) {

var requestId = e.requestId;