chrome/browser/guest_view/guest_view_base.cc - Issue 307543005: Fix the Declarative WebRequest API for <webview>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/guest_view_base.cc

Issue 307543005: Fix the Declarative WebRequest API for <webview> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_webcontentsdelegate_impl_to_chrome

Patch Set: Addressed remainder of comments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/declarative_webrequest/webrequest_action.cc ('K') | « chrome/browser/guest_view/guest_view.h ('k') | chrome/browser/guest_view/web_view/web_view_constants.h » ('j') | chrome/renderer/resources/extensions/web_view.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/guest_view/guest_view_base.cc

diff --git a/chrome/browser/guest_view/guest_view_base.cc b/chrome/browser/guest_view/guest_view_base.cc

index 12f62c5ccb01fa6df1cfedfcb1d405758dc19318..f9786b401522e5d600a541729f861c83fc29f69e 100644

--- a/chrome/browser/guest_view/guest_view_base.cc

+++ b/chrome/browser/guest_view/guest_view_base.cc

@@ -234,7 +234,6 @@ void GuestViewBase::DispatchEvent(Event* event) {

Profile* profile = Profile::FromBrowserContext(browser_context_);

extensions::EventFilteringInfo info;

- info.SetURL(GURL());

info.SetInstanceID(guest_instance_id_);

scoped_ptr<base::ListValue> args(new base::ListValue());

args->Append(event->GetArguments().release());