chrome/browser/apps/web_view_browsertest.cc - Issue 307543005: Fix the Declarative WebRequest API for <webview>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/web_view_browsertest.cc

Issue 307543005: Fix the Declarative WebRequest API for <webview> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_webcontentsdelegate_impl_to_chrome

Patch Set: Addressed remainder of comments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/extensions/api/declarative_webrequest/webrequest_action.cc » ('j') | chrome/browser/extensions/api/declarative_webrequest/webrequest_action.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/apps/web_view_browsertest.cc

diff --git a/chrome/browser/apps/web_view_browsertest.cc b/chrome/browser/apps/web_view_browsertest.cc

index f4be00b023296157502941e4c91cd13093b0ad0f..ba3ea96b507dedf75ff08375b103f8034d8c0135 100644

--- a/chrome/browser/apps/web_view_browsertest.cc

+++ b/chrome/browser/apps/web_view_browsertest.cc

@@ -1003,12 +1003,19 @@ IN_PROC_BROWSER_TEST_F(WebViewTest, Shim_TestContentLoadEvent) {

// http://crbug.com/326330

IN_PROC_BROWSER_TEST_F(WebViewTest,

- DISABLED_Shim_TestDeclarativeWebRequestAPI) {

+ Shim_TestDeclarativeWebRequestAPI) {

TestHelper("testDeclarativeWebRequestAPI",

"web_view/shim",

NEEDS_TEST_SERVER);

}

+IN_PROC_BROWSER_TEST_F(WebViewTest,

+ Shim_TestDeclarativeWebRequestAPISendMessage) {

+ TestHelper("testDeclarativeWebRequestAPISendMessage",

+ "web_view/shim",

+ NEEDS_TEST_SERVER);

IN_PROC_BROWSER_TEST_F(WebViewTest, Shim_TestWebRequestAPI) {

TestHelper("testWebRequestAPI", "web_view/shim", NEEDS_TEST_SERVER);

}