Fix the Declarative WebRequest API for <webview>

chrome/browser/extensions/api/declarative_webrequest/webrequest_action.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/declarative_webrequest/webrequest_action.h"
 
 #include <limits>
 
 #include "base/lazy_instance.h"
 #include "base/logging.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/values.h"
 #include "chrome/browser/extensions/api/declarative/deduping_factory.h"
 #include "chrome/browser/extensions/api/declarative_webrequest/request_stage.h"
 #include "chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.h"
 #include "chrome/browser/extensions/api/declarative_webrequest/webrequest_constants.h"
 #include "chrome/browser/extensions/api/web_request/web_request_api_constants.h"
 #include "chrome/browser/extensions/api/web_request/web_request_api_helpers.h"
 #include "chrome/browser/extensions/api/web_request/web_request_permissions.h"
+#include "chrome/browser/extensions/extension_renderer_state.h"
+#include "content/public/browser/resource_request_info.h"
 #include "content/public/common/url_constants.h"
 #include "extensions/browser/info_map.h"
 #include "extensions/common/error_utils.h"
 #include "extensions/common/extension.h"
 #include "net/base/registry_controlled_domains/registry_controlled_domain.h"
 #include "net/url_request/url_request.h"
 #include "third_party/re2/re2/re2.h"
 
+using content::ResourceRequestInfo;
+
 namespace extensions {
 
 namespace helpers = extension_web_request_api_helpers;
 namespace keys = declarative_webrequest_constants;
 
 namespace {
 // Error messages.
 const char kIgnoreRulesRequiresParameterError[] =
     "IgnoreRules requires at least one parameter.";
 
@@ skipping 435 matching lines @@
                                      const net::URLRequest* request,
                                      bool crosses_incognito) const {
   if (WebRequestPermissions::HideRequest(extension_info_map, request))
     return false;
 
   // In unit tests we don't have an extension_info_map object here and skip host
   // permission checks.
   if (!extension_info_map)
     return true;
 
+  const ResourceRequestInfo* info = ResourceRequestInfo::ForRequest(request);
+  int process_id = info->GetChildID();
+  int route_id = info->GetRouteID();
+  ExtensionRendererState::WebViewInfo webview_info;
+  // The embedder can always access all hosts from within a <webview>.
+  // The same is not true of extensions.
+  if (ExtensionRendererState::GetInstance()->GetWebViewInfo(
+      process_id, route_id, &webview_info)) {

[lazyboy, 2014/05/29 17:50:14]

Indent 4 more spaces.

[Fady Samuel, 2014/05/29 18:44:45]

Done.

+    return true;
+  }
   WebRequestPermissions::HostPermissionsCheck permission_check =
       WebRequestPermissions::REQUIRE_ALL_URLS;
   switch (host_permissions_strategy()) {
     case STRATEGY_DEFAULT:  // Default value is already set.
       break;
     case STRATEGY_NONE:
       permission_check = WebRequestPermissions::DO_NOT_CHECK_HOST;
       break;
     case STRATEGY_HOST:
       permission_check = WebRequestPermissions::REQUIRE_HOST_PERMISSION;
@@ skipping 652 matching lines @@
     const base::Time& extension_install_time) const {
   CHECK(request_data.stage & stages());
   LinkedPtrEventResponseDelta result(
       new extension_web_request_api_helpers::EventResponseDelta(
           extension_id, extension_install_time));
   result->messages_to_extension.insert(message_);
   return result;
 }
 
 }  // namespace extensions