Move common accelerator code from ash to ui/wm/core

Move common accelerator code from ash to ui/wm/core

accelerator_filter_unittest stays in ash because it requires ash.

BUG=375534
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273811

[sky, 2014-05-28 23:01:27]

https://codereview.chromium.org/307533007/diff/80001/ui/wm/core/accelerator_f...
File ui/wm/core/accelerator_filter.cc (right):

https://codereview.chromium.org/307533007/diff/80001/ui/wm/core/accelerator_f...
ui/wm/core/accelerator_filter.cc:77: if
(!delegate_->ShouldProcessAcceleratorNow(*event, accelerator))
Why do we need ShouldProcess and Process? Process has a return value, so can't
the delegate return false if it didn't process it?

https://codereview.chromium.org/307533007/diff/80001/ui/wm/core/accelerator_f...
File ui/wm/core/accelerator_filter.h (right):

https://codereview.chromium.org/307533007/diff/80001/ui/wm/core/accelerator_f...
ui/wm/core/accelerator_filter.h:20: AcceleratorFilter(AcceleratorDelegate*
delegate);
Make this take a scoped_ptr.

https://codereview.chromium.org/307533007/diff/80001/ui/wm/core/accelerator_f...
ui/wm/core/accelerator_filter.h:28: DISALLOW_COPY_AND_ASSIGN(AcceleratorFilter);
nit: newline between 27/28.

[oshima, 2014-05-29 06:15:46]

https://codereview.chromium.org/307533007/diff/80001/ui/wm/core/accelerator_f...
File ui/wm/core/accelerator_filter.cc (right):

https://codereview.chromium.org/307533007/diff/80001/ui/wm/core/accelerator_f...
ui/wm/core/accelerator_filter.cc:77: if
(!delegate_->ShouldProcessAcceleratorNow(*event, accelerator))
On 2014/05/28 23:01:27, sky wrote:
> Why do we need ShouldProcess and Process? Process has a return value, so can't
> the delegate return false if it didn't process it?

This is becaues ProcessAccelerator is called without ShouldProcessAcceleratorNow
in if block above, and jamescook (who added this if block) wasn't sure if it's
safe to merge the logic. I can look into if we can merge them, but want to do it
in separate CL as it may cause a regression.

https://codereview.chromium.org/307533007/diff/80001/ui/wm/core/accelerator_f...
File ui/wm/core/accelerator_filter.h (right):

https://codereview.chromium.org/307533007/diff/80001/ui/wm/core/accelerator_f...
ui/wm/core/accelerator_filter.h:20: AcceleratorFilter(AcceleratorDelegate*
delegate);
On 2014/05/28 23:01:27, sky wrote:
> Make this take a scoped_ptr.

Done.

https://codereview.chromium.org/307533007/diff/80001/ui/wm/core/accelerator_f...
ui/wm/core/accelerator_filter.h:28: DISALLOW_COPY_AND_ASSIGN(AcceleratorFilter);
On 2014/05/28 23:01:27, sky wrote:
> nit: newline between 27/28.

Done.

https://codereview.chromium.org/307533007/diff/120001/ui/wm/core/accelerator_...
File ui/wm/core/accelerator_delegate.h (right):

https://codereview.chromium.org/307533007/diff/120001/ui/wm/core/accelerator_...
ui/wm/core/accelerator_delegate.h:20: virtual void PreProcessAccelerator(const
ui::Accelerator& accelerator) = 0;
This is new change I added per mtomaz@ suggestion. (I was asking if it's safe to
move this logic to ProcessAccelerator, but it wasn't safe)

FYI: I'll try to eliminate this in seprate CL, as noted in TODO.

[sky, 2014-05-29 15:29:41]

LGTM - but please merge these functions. I don't understand why we need so many.

[oshima, 2014-05-29 16:13:34]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-05-29 16:15:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/oshima@chromium.org/307533007/120001

[commit-bot: I haz the power, 2014-05-29 19:37:25]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/7...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)

[oshima, 2014-05-29 21:34:59]

The CQ bit was unchecked by oshima@chromium.org

[commit-bot: I haz the power, 2014-05-29 21:36:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-29 21:36:27]

Try jobs failed on following builders:
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)

[oshima, 2014-05-29 21:53:29]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-05-29 21:55:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/oshima@chromium.org/307533007/160001

[commit-bot: I haz the power, 2014-05-30 02:34:51]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-30 06:33:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-30 06:33:24]

Try jobs failed on following builders:
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[oshima, 2014-05-30 12:49:54]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-05-30 12:51:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/oshima@chromium.org/307533007/180001

[commit-bot: I haz the power, 2014-05-30 13:07:05]

Change committed as 273811