Issue 307533002: Mojo: Move common type/constant definitions from mojo/public/c/system/core.h to .../types.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 307533002: Mojo: Move common type/constant definitions from mojo/public/c/system/core.h to .../types.h. (Closed)

Created:
6 years, 7 months ago by viettrungluu

Modified:
6 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mojo: Move common type/constant definitions from mojo/public/c/system/core.h to .../types.h. The plan is to further split the file: functions.h (or something like that) for common/basic functions, message_pipe.h, data_pipe.h, etc. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273008

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+179 lines, -157 lines)			Patch
M	mojo/mojo_public.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	mojo/public/c/system/core.h	View	1 chunk	+2 lines, -149 lines	0 comments	Download
A	mojo/public/c/system/types.h	View	1 chunk	+167 lines, -0 lines	0 comments	Download
M	mojo/system/channel.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/system/core.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	mojo/system/core.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	mojo/system/core_test_base.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/system/handle_table.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/system/mapping_table.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/system/waiter.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/system/waiter_list.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/system/waiter_test_utils.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/307533002/1

6 years, 7 months ago (2014-05-27 18:27:09 UTC) #4

viettrungluu

6 years, 7 months ago (2014-05-27 19:31:07 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r273008 (presubmit successful).

Expand Messages | Collapse Messages