chrome/utility/wifi/wifi_service.h - Issue 30753002: Move GetVisibleNetworks network type filtering to WiFiService interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/utility/wifi/wifi_service.h

Issue 30753002: Move GetVisibleNetworks network type filtering to WiFiService interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address codereview comments. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/utility/wifi/wifi_service.h

diff --git a/chrome/utility/wifi/wifi_service.h b/chrome/utility/wifi/wifi_service.h

index f743786428aaf45231b7ccb2ca454d090f3c699e..e45c07e6023236f8f8c693e6260ad1debd32ca1f 100644

--- a/chrome/utility/wifi/wifi_service.h

+++ b/chrome/utility/wifi/wifi_service.h

@@ -111,9 +111,10 @@ class WiFiService {

const StringResultCallback& callback,

const ErrorCallback& error_callback) = 0;

- // Get list of visible networks. Run |callback| on success, |error_callback|

- // on failure.

- virtual void GetVisibleNetworks(const NetworkListCallback& callback,

+ // Get list of visible networks of |network_type|. Run |callback| on success,

+ // |error_callback| on failure.

+ virtual void GetVisibleNetworks(const std::string& network_type,

+ const NetworkListCallback& callback,

const ErrorCallback& error_callback) = 0;

// Request network scan. Send |NetworkListChanged| event on completion.

« no previous file with comments | « chrome/utility/networking_private_handler.cc ('k') | chrome/utility/wifi/wifi_service_mock.cc » ('j') | no next file with comments »