Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 307503003: ServiceWorker: Print error message when failed to open diskcache (Closed)

Created:
6 years, 7 months ago by nhiroki
Modified:
6 years, 7 months ago
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, alecflett+watch_chromium.org
Visibility:
Public.

Description

ServiceWorker: Print error message when failed to open diskcache BUG=371675 TEST=n/a NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272970

Patch Set 1 #

Patch Set 2 : Use net::ErrorToString() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M content/browser/service_worker/service_worker_storage.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
nhiroki
Anyone can review this? If this looks good to you, please check the CQ. Thanks!
6 years, 7 months ago (2014-05-27 12:13:59 UTC) #1
horo
lgtm
6 years, 7 months ago (2014-05-27 12:14:49 UTC) #2
nhiroki
The CQ bit was checked by nhiroki@chromium.org
6 years, 7 months ago (2014-05-27 12:21:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/307503003/20001
6 years, 7 months ago (2014-05-27 12:21:30 UTC) #4
nhiroki
The CQ bit was unchecked by nhiroki@chromium.org
6 years, 7 months ago (2014-05-27 12:27:03 UTC) #5
nhiroki
The CQ bit was checked by nhiroki@chromium.org
6 years, 7 months ago (2014-05-27 12:27:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/307503003/20001
6 years, 7 months ago (2014-05-27 12:27:46 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-27 14:03:10 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-27 14:08:14 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/77902)
6 years, 7 months ago (2014-05-27 14:08:15 UTC) #10
nhiroki
The CQ bit was checked by nhiroki@chromium.org
6 years, 7 months ago (2014-05-27 14:37:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/307503003/20001
6 years, 7 months ago (2014-05-27 14:37:27 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-05-27 14:38:29 UTC) #13
Message was sent while issue was closed.
Change committed as 272970

Powered by Google App Engine
This is Rietveld 408576698