Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 307483002: Desktop user manager: Adjustments for supervised users. (Closed)

Created:
6 years, 7 months ago by Marc Treib
Modified:
6 years, 6 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Desktop user manager: Adjustments for supervised users. The changes are: - Show a supervised user icon. Note that this has a different look than on CrOS, to fit in with the "lock" icon on desktop. (The final icon resource is still missing, but since this must land in time for M37 I'm already sending the code for review now, and will switch out the icon later.) - Use the supervised user deletion warning text from CrOS also for supervised users on desktop. Mocks at https://folio.googleplex.com/chrome-ux/mocks/064-chrome-away-from-chrome/supervised/mirror BUG=372812, 310640 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274215

Patch Set 1 #

Patch Set 2 : Cleanup #

Patch Set 3 : Get rid of isDesktopSupervisedUser. #

Total comments: 2

Patch Set 4 : Rebase + RTL friendly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -16 lines) Patch
M chrome/app/generated_resources.grd View 1 2 3 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/resources/login/user_pod_row.js View 1 2 8 chunks +38 lines, -5 lines 0 comments Download
M chrome/browser/resources/login/user_pod_template.html View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/resources/user_manager/user_manager.css View 1 2 3 1 chunk +16 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/signin/user_manager_screen_handler.cc View 1 2 3 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Marc Treib
Hi Nikita and Monica, PTAL! [Nikita owns all the files in this CL, but adding ...
6 years, 7 months ago (2014-05-27 12:34:39 UTC) #1
Nikita (slow)
I'll let Denis review this since he's working on supervised users on Chrome OS.
6 years, 7 months ago (2014-05-27 13:29:58 UTC) #2
Denis Kuznetsov (DE-MUC)
lgtm
6 years, 6 months ago (2014-05-28 12:51:23 UTC) #3
noms (inactive)
lgtm
6 years, 6 months ago (2014-05-28 13:44:49 UTC) #4
Marc Treib
Hi Nikita, can you review the change in user_manager.css, since neither Denis nor Monica own ...
6 years, 6 months ago (2014-05-28 13:52:16 UTC) #5
Nikita (slow)
https://chromiumcodereview.appspot.com/307483002/diff/40001/chrome/browser/resources/user_manager/user_manager.css File chrome/browser/resources/user_manager/user_manager.css (right): https://chromiumcodereview.appspot.com/307483002/diff/40001/chrome/browser/resources/user_manager/user_manager.css#newcode82 chrome/browser/resources/user_manager/user_manager.css:82: left: 10px; Please make this RTL friendly.
6 years, 6 months ago (2014-05-28 14:54:05 UTC) #6
Nikita (slow)
On 2014/05/28 14:54:05, Nikita Kostylev wrote: > https://chromiumcodereview.appspot.com/307483002/diff/40001/chrome/browser/resources/user_manager/user_manager.css > File chrome/browser/resources/user_manager/user_manager.css (right): > > https://chromiumcodereview.appspot.com/307483002/diff/40001/chrome/browser/resources/user_manager/user_manager.css#newcode82 ...
6 years, 6 months ago (2014-05-28 14:55:14 UTC) #7
Marc Treib
https://chromiumcodereview.appspot.com/307483002/diff/40001/chrome/browser/resources/user_manager/user_manager.css File chrome/browser/resources/user_manager/user_manager.css (right): https://chromiumcodereview.appspot.com/307483002/diff/40001/chrome/browser/resources/user_manager/user_manager.css#newcode82 chrome/browser/resources/user_manager/user_manager.css:82: left: 10px; On 2014/05/28 14:54:06, Nikita Kostylev wrote: > ...
6 years, 6 months ago (2014-05-28 15:10:47 UTC) #8
Nikita (slow)
On 2014/05/28 15:10:47, treib wrote: > https://chromiumcodereview.appspot.com/307483002/diff/40001/chrome/browser/resources/user_manager/user_manager.css > File chrome/browser/resources/user_manager/user_manager.css (right): > > https://chromiumcodereview.appspot.com/307483002/diff/40001/chrome/browser/resources/user_manager/user_manager.css#newcode82 > ...
6 years, 6 months ago (2014-05-28 15:13:49 UTC) #9
noms (inactive)
Sure, I'll whip up a CL later on today. On 2014/05/28 15:13:49, Nikita Kostylev wrote: ...
6 years, 6 months ago (2014-05-28 15:14:50 UTC) #10
Nikita (slow)
lgtm
6 years, 6 months ago (2014-05-29 07:54:58 UTC) #11
noms (inactive)
CL created here: https://codereview.chromium.org/303193002/ On 2014/05/29 07:54:58, Nikita Kostylev wrote: > lgtm
6 years, 6 months ago (2014-05-29 16:49:45 UTC) #12
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 6 months ago (2014-06-02 07:56:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/307483002/50001
6 years, 6 months ago (2014-06-02 07:56:43 UTC) #14
commit-bot: I haz the power
6 years, 6 months ago (2014-06-02 12:38:28 UTC) #15
Message was sent while issue was closed.
Change committed as 274215

Powered by Google App Engine
This is Rietveld 408576698