Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1025)

Issue 307473002: Use embedded thumbnails in the grid view. (Closed)

Created:
6 years, 7 months ago by mtomasz
Modified:
6 years, 7 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Visibility:
Public.

Description

Use embedded thumbnails in the grid view. Since libjpeg-turbo got disabled, loading high-resolution jpeg files became very slow. However, the thumbnails in the grid view became smaller, some time ago, so we can use the embedded thumbnails (if available). Note, that this may significantly affect image quality of thumbnails, especially on hi-dpi screens. TEST=Tested manually with large pictures from a camera. BUG=373636 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272947

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ui/file_manager/file_manager/foreground/js/file_grid.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mtomasz
@hirono: PTAL. Thanks.
6 years, 7 months ago (2014-05-27 08:33:01 UTC) #1
hirono
lgtm!
6 years, 7 months ago (2014-05-27 08:35:24 UTC) #2
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 7 months ago (2014-05-27 08:36:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/307473002/1
6 years, 7 months ago (2014-05-27 08:36:30 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-27 11:42:52 UTC) #5
Message was sent while issue was closed.
Change committed as 272947

Powered by Google App Engine
This is Rietveld 408576698