Client-side changes to support requesting lossless encode & color.

remoting/webapp/client_plugin.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * Class that wraps low-level details of interacting with the client plugin.
  *
  * This abstracts a <embed> element and controls the plugin which does
  * the actual remoting work. It also handles differences between
@@ skipping 86 matching lines @@
   NOTIFY_CLIENT_RESOLUTION: 'notifyClientResolution',
   ASYNC_PIN: 'asyncPin',
   PAUSE_VIDEO: 'pauseVideo',
   PAUSE_AUDIO: 'pauseAudio',
   REMAP_KEY: 'remapKey',
   SEND_CLIPBOARD_ITEM: 'sendClipboardItem',
   THIRD_PARTY_AUTH: 'thirdPartyAuth',
   TRAP_KEY: 'trapKey',
   PINLESS_AUTH: 'pinlessAuth',
   EXTENSION_MESSAGE: 'extensionMessage',
-  MEDIA_SOURCE_RENDERING: 'mediaSourceRendering'
+  MEDIA_SOURCE_RENDERING: 'mediaSourceRendering',
+  VIDEO_CONTROL: 'videoControl',
 };
 
 /**
  * Chromoting session API version (for this javascript).
  * This is compared with the plugin API version to verify that they are
  * compatible.
  *
  * @const
  * @private
  */
@@ skipping 423 matching lines @@
   }
 };
 
 /**
  * Requests that the host pause or resume sending video updates.
  *
  * @param {boolean} pause True to suspend video updates, false otherwise.
  */
 remoting.ClientPlugin.prototype.pauseVideo =
     function(pause) {
-  if (!this.hasFeature(remoting.ClientPlugin.Feature.PAUSE_VIDEO)) {
-    return;
+  if (this.hasFeature(remoting.ClientPlugin.Feature.VIDEO_CONTROL)) {
+    this.plugin.postMessage(JSON.stringify(
+        { method: 'videoControl', data: { enable: !pause }}));
+  } else if (this.hasFeature(remoting.ClientPlugin.Feature.PAUSE_VIDEO)) {
+    this.plugin.postMessage(JSON.stringify(
+        { method: 'pauseVideo', data: { pause: pause }}));
   }
-  this.plugin.postMessage(JSON.stringify(
-      { method: 'pauseVideo', data: { pause: pause }}));
 };
 
 /**
  * Requests that the host pause or resume sending audio updates.
  *
  * @param {boolean} pause True to suspend audio updates, false otherwise.
  */
 remoting.ClientPlugin.prototype.pauseAudio =
     function(pause) {
   if (!this.hasFeature(remoting.ClientPlugin.Feature.PAUSE_AUDIO)) {
     return;
   }
   this.plugin.postMessage(JSON.stringify(
       { method: 'pauseAudio', data: { pause: pause }}));
 };
 
 /**
+ * Requests that the host configure the video codec for lossless encode.
+ *
+ * @param {boolean} want_lossless True to request lossless encoding.

[Jamie, 2014/05/28 22:21:19]

Nit: camelCase :)

[Wez, 2014/05/28 22:41:07]

Done.

+ */
+remoting.ClientPlugin.prototype.setLosslessEncode =
+    function(want_lossless) {
+  if (!this.hasFeature(remoting.ClientPlugin.Feature.VIDEO_CONTROL)) {
+    return;
+  }
+  this.plugin.postMessage(JSON.stringify(
+      { method: 'videoControl', data: { lossless_encode: want_lossless }}));

[Jamie, 2014/05/28 22:21:19]

Nit: Quotes around dictionary keys, for consistency.

[Wez, 2014/05/28 22:41:07]

Not sure what you mean; this file consistently _doesn't_ put quotes around
dictionary keys (see pauseVideo, pauseAudio, etc).

[Jamie, 2014/05/28 22:53:56]

My mistake. I was reading 'videoControl' as a key rather than a value.

+};
+
+/**
+ * Requests that the host configure the video codec for lossless color.
+ *
+ * @param {boolean} want_lossless True to request lossless color.
+ */
+remoting.ClientPlugin.prototype.setLosslessColor =
+    function(want_lossless) {
+  if (!this.hasFeature(remoting.ClientPlugin.Feature.VIDEO_CONTROL)) {
+    return;
+  }
+  this.plugin.postMessage(JSON.stringify(
+      { method: 'videoControl', data: { lossless_color: want_lossless }}));
+};
+
+/**
  * Called when a PIN is obtained from the user.
  *
  * @param {string} pin The PIN.
  */
 remoting.ClientPlugin.prototype.onPinFetched =
     function(pin) {
   if (!this.hasFeature(remoting.ClientPlugin.Feature.ASYNC_PIN)) {
     return;
   }
   this.plugin.postMessage(JSON.stringify(
@@ skipping 87 matching lines @@
     this.plugin.style.width = width + 'px';
     this.plugin.style.height = height + 'px';
     // Center the plugin just underneath the "Connnecting..." dialog.
     var parentNode = this.plugin.parentNode;
     var dialog = document.getElementById('client-dialog');
     var dialogRect = dialog.getBoundingClientRect();
     parentNode.style.top = (dialogRect.bottom + 16) + 'px';
     parentNode.style.left = (window.innerWidth - width) / 2 + 'px';
   }
 };