Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 307463004: Remove PlatformFile from remoting (Closed)

Created:
6 years, 7 months ago by rvargas (doing something else)
Modified:
6 years, 6 months ago
Reviewers:
dcaiafa
CC:
chromium-reviews, chromoting-reviews_chromium.org
Visibility:
Public.

Description

Remove PlatformFile from remoting BUG=322664 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274761

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix compilation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -49 lines) Patch
M remoting/host/desktop_process_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/desktop_session_agent.h View 2 chunks +1 line, -4 lines 0 comments Download
M remoting/host/desktop_session_agent.cc View 6 chunks +10 lines, -20 lines 0 comments Download
M remoting/host/desktop_session_proxy.cc View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/ipc_desktop_environment.cc View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/host/ipc_util.h View 2 chunks +2 lines, -1 line 0 comments Download
M remoting/host/ipc_util_posix.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M remoting/host/ipc_util_win.cc View 3 chunks +11 lines, -11 lines 0 comments Download
M remoting/host/native_messaging/native_messaging_reader_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/native_messaging/native_messaging_writer_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/host/win/unprivileged_process_delegate.cc View 1 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
rvargas (doing something else)
PTAL
6 years, 6 months ago (2014-05-28 03:06:16 UTC) #1
Wez
This looks fine to me, but adding Dan, who's the expert.
6 years, 6 months ago (2014-05-29 00:11:16 UTC) #2
rvargas (doing something else)
ping
6 years, 6 months ago (2014-06-02 23:29:29 UTC) #3
dcaiafa
lgtm after fixing unprivileged_process_delegate.cc. Sorry for the delay. The change looked clean but I wanted ...
6 years, 6 months ago (2014-06-03 22:48:02 UTC) #4
rvargas (doing something else)
Thanks a lot for catching that! https://codereview.chromium.org/307463004/diff/1/remoting/host/win/unprivileged_process_delegate.cc File remoting/host/win/unprivileged_process_delegate.cc (right): https://codereview.chromium.org/307463004/diff/1/remoting/host/win/unprivileged_process_delegate.cc#newcode290 remoting/host/win/unprivileged_process_delegate.cc:290: "%d", reinterpret_cast<ULONG_PTR>(client.Get())); On ...
6 years, 6 months ago (2014-06-03 22:59:32 UTC) #5
rvargas (doing something else)
The CQ bit was checked by rvargas@chromium.org
6 years, 6 months ago (2014-06-03 23:01:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/307463004/20001
6 years, 6 months ago (2014-06-03 23:02:20 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium ...
6 years, 6 months ago (2014-06-04 02:39:07 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 10:57:24 UTC) #9
Message was sent while issue was closed.
Change committed as 274761

Powered by Google App Engine
This is Rietveld 408576698