Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Issue 307453007: device/bluetooth: Implement GATT characteristic properties on Chrome OS. (Closed)

Created:
6 years, 7 months ago by armansito
Modified:
6 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

device/bluetooth: Implement GATT characteristic properties on Chrome OS. This CL implements GATT characteristic properties for BluetoothRemoteGattCharacteristicChromeOS. Also, a typo in the "Writable Auxiliaries" property declaration has been fixed. BUG=362799 TEST=device_unittests, browser_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275599

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase & use constants from service_constants.h #

Patch Set 3 : Rebase #

Messages

Total messages: 11 (0 generated)
armansito
kalman@: For the IDL change. keybuk@: All else.
6 years, 7 months ago (2014-05-27 23:30:28 UTC) #1
not at google - send to devlin
feel free to tbr spelling corrections :)
6 years, 6 months ago (2014-05-28 14:58:19 UTC) #2
not at google - send to devlin
err, lgtm for idl.
6 years, 6 months ago (2014-05-28 14:58:25 UTC) #3
armansito
On 2014/05/28 14:58:19, kalman wrote: > feel free to tbr spelling corrections :) ah, will ...
6 years, 6 months ago (2014-05-29 03:00:21 UTC) #4
keybuk
https://codereview.chromium.org/307453007/diff/1/chromeos/dbus/bluetooth_gatt_characteristic_client.h File chromeos/dbus/bluetooth_gatt_characteristic_client.h (right): https://codereview.chromium.org/307453007/diff/1/chromeos/dbus/bluetooth_gatt_characteristic_client.h#newcode22 chromeos/dbus/bluetooth_gatt_characteristic_client.h:22: // TODO(armansito): Move these constants to service_constants.h Do it ...
6 years, 6 months ago (2014-05-30 22:24:55 UTC) #5
armansito
https://codereview.chromium.org/307453007/diff/1/chromeos/dbus/bluetooth_gatt_characteristic_client.h File chromeos/dbus/bluetooth_gatt_characteristic_client.h (right): https://codereview.chromium.org/307453007/diff/1/chromeos/dbus/bluetooth_gatt_characteristic_client.h#newcode22 chromeos/dbus/bluetooth_gatt_characteristic_client.h:22: // TODO(armansito): Move these constants to service_constants.h On 2014/05/30 ...
6 years, 6 months ago (2014-06-05 19:44:13 UTC) #6
keybuk
lgtm
6 years, 6 months ago (2014-06-06 17:53:36 UTC) #7
armansito
The CQ bit was checked by armansito@chromium.org
6 years, 6 months ago (2014-06-06 18:50:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/armansito@chromium.org/307453007/40001
6 years, 6 months ago (2014-06-06 18:53:06 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-06-06 22:31:33 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 03:16:59 UTC) #11
Message was sent while issue was closed.
Change committed as 275599

Powered by Google App Engine
This is Rietveld 408576698